From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id EM+tHeTcZmF2LgEAgWs5BA (envelope-from ) for ; Wed, 13 Oct 2021 15:19:32 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 8H9dGeTcZmEjNAAA1q6Kng (envelope-from ) for ; Wed, 13 Oct 2021 13:19:32 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1B355222B6 for ; Wed, 13 Oct 2021 15:19:31 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 8128E2C18E; Wed, 13 Oct 2021 09:19:29 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 79DB82C185 for ; Wed, 13 Oct 2021 09:19:22 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 660955FBE5; Wed, 13 Oct 2021 09:19:22 -0400 (EDT) Received: (nullmailer pid 2111385 invoked by uid 1000); Wed, 13 Oct 2021 13:19:21 -0000 From: David Bremner To: Jani Nikula , notmuch@notmuchmail.org Cc: jani@nikula.org Subject: Re: [RFC 3/5] lib: remove commented out NOTMUCH_DEPRECATED() In-Reply-To: <20211012185127.198348-4-jani@nikula.org> References: <20211012185127.198348-1-jani@nikula.org> <20211012185127.198348-4-jani@nikula.org> Date: Wed, 13 Oct 2021 10:19:21 -0300 Message-ID: <87v921kqp2.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: FSKCIHR6JUWVYEIJY3MGCQ3ZI4S7JVUM X-Message-ID-Hash: FSKCIHR6JUWVYEIJY3MGCQ3ZI4S7JVUM X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634131172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=2+PGPeunAxqwQXP6GEPt0ZxGh354t0yybReSBf/E3ZI=; b=UaMea1Q27AjUfpuEGMyHUIl0c5XPS21XcHjuTOyawikHT1hMyIIwB7biaC3QT7A5wWD32I QvurfeTp9QMtRVvGta82SgHxAJc4JK1sr/ifS0hWyxylApyfZWxCnGbfnRMVIRlf5DxgVq GUH+vIrq4roXzYGrURvIGX6q+Z7wwpHDeTOfwHU1pBNLXMFxcxS6cA8aP/gZmsypGwwtL+ C7wo1gC1pvNw/c9IIp0RBQ8Qj1ieZ3bY/eYqCTtHTEguIH671/FCdyz9ZadFw/BECFQxRC GXKgZhNwI/wD2GOI30jhphbAaTPeC8Lk0U8VQSbaY0MXJ5N81EUabbdeDkI1TA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634131172; a=rsa-sha256; cv=none; b=Edj0KoCH+pgOWgjbwFI7SQG5ojHZfmU9M81bb3YbZpHSf/MUe+GeZhDqzYaBEemfyfVtM/ WOcCftVbvOAvYTLaVmzXkdMOMYZsNnU8RqFejctf1AbMwFWG58MkCru0YYk9v6ksSfjtPc cQPr+lzPZBgDodDj98ibUpphq9ALsQOUAV2X64dyRo8tHKV6B1IkBlDKkOwZvwLl2IXD5h kSVrxC3EdKDvaVADKq1ByTV+LoLVf9EI1BmE89MSzfNrXXX7+xf2CwXHcGo/bH1R3/bPPK 1UyAiPNZPBL1pLVxZVJd1qQIGjMrP6H7DQZpMYkUMIXLmqX0Q3BxlxGoRDRfUA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.17 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 1B355222B6 X-Spam-Score: -2.17 X-Migadu-Scanner: scn0.migadu.com X-TUID: 48dVJNodSqt8 Jani Nikula writes: > Having comments between the documentation comment and the object being > documented throws Hawkmoth off. Remove the placeholder > NOTMUCH_DEPRECATED() comments. > > --- > > They were added in commit e5f3c3ed5024 ("lib: add stub for > notmuch_database_open_with_config"); maybe the comment markers should > be removed instead? Yes, those should be uncommented, I think. d