From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id UPHqMv055WKvKAAAbAwnHQ (envelope-from ) for ; Sat, 30 Jul 2022 16:02:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id eFbgMv055WI5egEAauVa8A (envelope-from ) for ; Sat, 30 Jul 2022 16:02:37 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 61B122B0E8 for ; Sat, 30 Jul 2022 16:02:37 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 21D2E5F385; Sat, 30 Jul 2022 14:02:35 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id B1A6F5F379 for ; Sat, 30 Jul 2022 14:02:32 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 0E02F5FBC0; Sat, 30 Jul 2022 10:02:32 -0400 (EDT) Received: (nullmailer pid 2453556 invoked by uid 1000); Sat, 30 Jul 2022 14:02:31 -0000 From: David Bremner To: Mohsin Kaleem , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: add new option notmuch-search-exclude In-Reply-To: <87ilnmw7kf.fsf@kisara.moe> References: <20211128200207.3455217-1-mohkale@kisara.moe> <8735mij0yo.fsf@tethera.net> <87pmme86cm.fsf@kisara.moe> <8735j9aj4u.fsf@tethera.net> <87wngl4w2n.fsf@kisara.moe> <87zglh92ry.fsf@tethera.net> <87o81xhhto.fsf@kisara.moe> <87v8w591v2.fsf@tethera.net> <87k0clhgw6.fsf@kisara.moe> <87pmm9n7sd.fsf@tethera.net> <87ilnmw7kf.fsf@kisara.moe> Date: Sat, 30 Jul 2022 11:02:31 -0300 Message-ID: <87v8re66mg.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 4PMQS3QGY7YQHITXDJG6AEXVSTOYZ4EU X-Message-ID-Hash: 4PMQS3QGY7YQHITXDJG6AEXVSTOYZ4EU X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1659189757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=gmYBohfeimfVXO2duyXC+KWFacnNwCPwyX4X4ixsj64=; b=QJfth2L4AxNhPRsmCzRT4vypCEBm24dR8ngvLFyX7iFTYS9I4Ys1XKNPDU2GoanBGvcH0Q ER06auaOG3GuiZXA6ivhm/qXOZEE7CRDs+W6sytxVTOekOEImrAH+/FYIHEn81cixZ0Ssp Olwv8h3U+td3waio2AosmErKdKsISPqMo1wWnxyg2bUmqazgQVpFkNLlW7xmxZTCGpPVAK 5zgPgCk8uzVq1hwtJZ3IlolysC2HAdSfX8C6MvjX3xT7YSDfmPJ53mlVqgUnJvF+/BxA32 hT+KDOw6qYlS/X5cK1eqSdqx1VHCt/47Ll3KpwOpeKLLtMw6Rq9n260Iw7uc1A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1659189757; a=rsa-sha256; cv=none; b=GDYXyetqzxelOjg1D5vzSGk/ijrohdpNG8cq0uzsEHxQR2b3gFj5fnfzP0+oQndhpYZP7l sxoIO0t4UMwV322oNtrWZRWqywJrZGuXXrmcLoH64Snp2ACWGfMcnmSFOSomVdWe7r8Fxs mkFIUxQOHAr1E6OZfMdNtRl0SjwbsYvTrNE2Vm095Jtl7dO12cVxTNCrAwoipI9wAahUu/ MZgbB5CBLfOo2rgjOo28PkRAxm50soXRG+kcj3lnfPLBevzBCt0MAJr140Nzp7iTbIqM60 wBtCeoipbnjSYmCuJeAUgXY+QIB0xhTwNIMRYvxlT9RNSSVkOmLdU87eJmGPsQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.29 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 61B122B0E8 X-Spam-Score: -2.29 X-Migadu-Scanner: scn1.migadu.com X-TUID: ZCtw/1z2c/V+ Mohsin Kaleem writes: > David Bremner writes: > > Hi, firstly sorry for taking so long to come back to this. I honestly > have tried to fix this multiple times since my last message but kept > getting confused or misdirected by how the tests are setup so I gave up > and decided to come back to it later. Today I finally just sped through > everything and think I have everything ready. > I think the patch series needs a bit of cleanup still. The first two patches occur twice and then a later patch is reverted (so presumably those two can be dropped as well). If possible, please use git send-email to send one-patch-per-message, it makes reviewing in notmuch-emacs much easier for me. You may also want to rebase against master before resending, since I have just a applied some changes to the emacs UI code that might collide with yours. d