From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id EN4IBKF8H2PmIAEAbAwnHQ (envelope-from ) for ; Mon, 12 Sep 2022 20:38:25 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id gBgYBKF8H2PRaAEA9RJhRA (envelope-from ) for ; Mon, 12 Sep 2022 20:38:25 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9BF6A1A2D7 for ; Mon, 12 Sep 2022 20:38:24 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id C85785DD5B; Mon, 12 Sep 2022 18:38:21 +0000 (UTC) Received: from che.mayfirst.org (unknown [162.247.75.117]) by mail.notmuchmail.org (Postfix) with ESMTPS id 49CD95DD59 for ; Mon, 12 Sep 2022 18:38:18 +0000 (UTC) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1663007896; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=RSAWz2fJBBYEVo8pEH+dLefP8htNZYfVfVePjeSXpMc=; b=u9K+48zoL3XbWvlpfIEqMQoAOAMDpRqnj4SxWTheSrZdx+BqRWEZx4XS7xvtzuqMw814L S8nL8L/bY3KzRknDA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1663007896; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=RSAWz2fJBBYEVo8pEH+dLefP8htNZYfVfVePjeSXpMc=; b=lf1QSlpguAmy9QSdxJ8GQWmBxSAxwhN5P3H8Lk5RzO1/jww4STAAkVYS2CdQLTJkjXmVr P6cE5hcZD7rdZbJWQqCTHiZQQFCeSbnV2kpUcm3fHZUA0oB9X+StNa3DbzuZNLiFYE8gqtU 7Tze/9WhdIhi7TByANa2TV+UUg/QQl5LXfS4lnxJPxolYY54fI2ck+CBERrwLtC2S3jktQE Vsui8tsc7JuGhM6/mG+xRZxC2FDVrBaK/pcNI9aGO53Y/w9Lp13ZnlxpfB4HVLkOE5RvVt1 RxX3gSisUx03B7I15BQBQZuqPxWdKEmk439aEZQ04WLxU7lwE2VdYojLyLfQ== Received: from fifthhorseman.net (lair.fifthhorseman.net [108.58.6.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-384)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 5F637F9AD for ; Mon, 12 Sep 2022 14:38:16 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 8AD11203D9; Mon, 12 Sep 2022 14:38:06 -0400 (EDT) From: Daniel Kahn Gillmor To: notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] test: compute expected keyid from fingerprint In-Reply-To: <87pmg14m3p.fsf@europ.lan> References: <20220909161250.715226-1-justus@sequoia-pgp.org> <87pmg14m3p.fsf@europ.lan> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEX+i03xYJKwYBBAHaRw8BAQdACA4xvL/xI5dHedcnkfViyq84doe8zFRid9jW7CC9XBiI0QQf FgoAgwWCX+i03wWJBZ+mAAMLCQcJEOCS6zpcoQ26RxQAAAAAAB4AIHNhbHRAbm90YXRpb25zLnNl cXVvaWEtcGdwLm9yZ/tr8E9NA10HvcAVlSxnox6z62KXCInWjZaiBIlgX6O5AxUKCAKbAQIeARYh BMKfigwB81402BaqXOCS6zpcoQ26AADZHQD/Zx9nc3N2kj13AUsKMr/7zekBtgfSIGB3hRCU74Su G44A/34Yp6IAkndewLxb1WdRSokycnaCVyrk0nb4imeAYyoPtBc8ZGtnQGZpZnRoaG9yc2VtYW4u bmV0PojRBBMWCgCDBYJf6LTfBYkFn6YAAwsJBwkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3Rh dGlvbnMuc2VxdW9pYS1wZ3Aub3JnL0Gwxvypz2tu1IPG+yu1zPjkiZwpscsitwrVvzN3bbADFQoI ApsBAh4BFiEEwp+KDAHzXjTYFqpc4JLrOlyhDboAAPkXAP0Z29z7jW+YzLzPTQML4EQLMbkHOfU4 +s+ki81Czt0WqgD/SJ8RyrqDCtEP8+E4ZSR01ysKqh+MUAsTaJlzZjehiQ24MwRf6LTfFgkrBgEE AdpHDwEBB0DkKHOW2kmqfAK461+acQ49gc2Z6VoXMChRqobGP0ubb4kBiAQYFgoBOgWCX+i03wWJ BZ+mAAkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3Jnfvo+ nHoxDwaLaJD8XZuXiaqBNZtIGXIypF1udBBRoc0CmwICHgG+oAQZFgoAbwWCX+i03wkQPp1xc3He VlxHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3JnaheiqE7Pfi3Atb3GGTw+ jFcBGOaobgzEJrhEuFpXREEWIQQttUkcnfDcj0MoY88+nXFzcd5WXAAAvrsBAIJ5sBg8Udocv25N stN/zWOiYpnjjvOjVMLH4fV3pWE1AP9T6hzHz7hRnAA8d01vqoxOlQ3O6cb/kFYAjqx3oMXSBhYh BMKfigwB81402BaqXOCS6zpcoQ26AADX7gD/b83VObe14xrNP8xcltRrBZF5OE1rQSPkMNy+eWpk eCwA/1hxiS8ZxL5/elNjXiWuHXEvUGnRoVj745Vl48sZPVYMuDgEX+i03xIKKwYBBAGXVQEFAQEH QIGex1WZbH6xhUBve5mblScGYU+Y8QJOomXH+rr5tMsMAwEICYjJBBgWCgB7BYJf6LTfBYkFn6YA CRDgkus6XKENukcUAAAAAAAeACBzYWx0QG5vdGF0aW9ucy5zZXF1b2lhLXBncC5vcmcEAx9vTD3b J0SXkhvcRcCr6uIDJwic3KFKxkH1m4QW0QKbDAIeARYhBMKfigwB81402BaqXOCS6zpcoQ26AAAX mwD8CWmukxwskU82RZLMk5fm1wCgMB5z8dA50KLw3rgsCykBAKg1w/Y7XpBS3SlXEegIg1K1e6dR fRxL7Z37WZXoH8AH Date: Mon, 12 Sep 2022 14:38:05 -0400 Message-ID: <87v8pso2uq.fsf@fifthhorseman.net> MIME-Version: 1.0 Message-ID-Hash: 2LUG6JQLE7QP3H272D3W5GGY4CNUKHQQ X-Message-ID-Hash: 2LUG6JQLE7QP3H272D3W5GGY4CNUKHQQ X-MailFrom: dkg@fifthhorseman.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: multipart/mixed; boundary="===============2802972422250893854==" X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1663007904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature:autocrypt:autocrypt; bh=MWxORcX77KumtBd87s7ds+tQBvB9p+BmR88HRUqVedM=; b=eQjBQ7tJB6T/Q1HavZUg1gEpPuuoIQ9wYdcQX/UOLgWLQdwtd8GrXbvhseyJFGLTg6fHgW IqibehWJIIQlFWeqNlsOVcBOVIc/hViQhedWG+P7Xe8ow/EdlWJf6VBaf2ggqRV7AShYPJ Rkfl++ODmx/m3zufqqiUDEAsewSVNXHaYRgvOr66AbxuB8olRZQ/6MFMxbSFEouJT+2JuC 93OcFdcyOU2dTpEfnh0DyckA/vLBDWGSuvKo77WzLiWbt+wQIWIJwedzoV8H0Ot1X9fRcq Li5dKZ97kIujChDZrr+sM3jfiMQaqBYddE+2lVeEJ9+PQYWU1+3dWRepUgJEug== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1663007904; a=rsa-sha256; cv=none; b=aruqyryDSEU2AH0rXS/LghMT+pJLRpu4l2q2eq5+1IIYE6p6sYBKl1IcsHUYy6CcQuiroR 81hQ8mxMSpRgUrJEy0QkWW1XxXzKJfXsyEPBZ7vX1YXV9zcEwtUOCt1LT9pu44L0W8YCjt 2mBlYECVyL6YVN1ugHiIxoepD17JFE8VQDIA4XDLeb2axk1e4UYuKT+tIRDuyAGFaJGzW6 XnweOf0MgBhNGQi7yag2FUVRXJLUeQ1xbLpvGnbQ9QBBqWIeDvfb1UF01pRRDXGjInxVjI D3s1BmSvnsbc8uemK66lCOUSSf+nb3JSFpLlMbZ/QF5CG5IlkkFZAtXRn40kow== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=fifthhorseman.net header.s=2019 header.b=u9K+48zo; dkim=fail ("body hash did not verify") header.d=fifthhorseman.net header.s=2019rsa header.b=lf1QSlpg; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fifthhorseman.net (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 4.70 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=fifthhorseman.net header.s=2019 header.b=u9K+48zo; dkim=fail ("body hash did not verify") header.d=fifthhorseman.net header.s=2019rsa header.b=lf1QSlpg; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fifthhorseman.net (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 9BF6A1A2D7 X-Spam-Score: 4.70 X-Migadu-Scanner: scn1.migadu.com X-TUID: rvs6lI0++L1L --===============2802972422250893854== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain On Sun 2022-09-11 23:50:18 +0200, Justus Winter wrote: > Tomi Ollila writes: > >> On Fri, Sep 09 2022, Justus Winter wrote: >> >>> --- >>> test/T350-crypto.sh | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh >>> index 3c6626b4..721cbfdd 100755 >>> --- a/test/T350-crypto.sh >>> +++ b/test/T350-crypto.sh >>> @@ -467,7 +467,7 @@ expected='[[[{"id": "XXXXX", >>> "Date": "Sat, 01 Jan 2000 12:00:00 +0000"}, >>> "body": [{"id": 1, >>> "sigstatus": [{"status": "error", >>> - "keyid": "6D92612D94E46381", >>> + "keyid": "'$(echo $FINGERPRINT | cut -c 25-)'", >> >> The "bashism" (works also in zsh) ${FINGERPRINT:24} works here >> (and has been used in other lines in this file > > Interesting. FTR, I saw this method being used elsewhere and simply > copied it. If that'd prevent merging the change, I'd actually prefer > introducing a variable KEYID that is set explicitly in the test library. > The reason for that is that in v5 OpenPGP, the keyid will be computed > differently. I don't think this should prevent merging the change -- Tomi is just offering an efficiency improvement. i'd also be happy with the introduction of an explicitly-set KEYID variable. These could be distinct changes. --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQQttUkcnfDcj0MoY88+nXFzcd5WXAUCYx98jgAKCRA+nXFzcd5W XKuoAQCTOWnP6GkEjCObsHpzcco8jM9PqSdLf/CdCEuExVqT8AD/fPLKaCYpCa3d GiGRLg7SRXjoHFDp4S/J9jiy7le6bAw= =Nm+J -----END PGP SIGNATURE----- --=-=-=-- --===============2802972422250893854== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============2802972422250893854==--