Re: [PATCH 1/2] test: compute expected keyid from fingerprint

[Daniel Kahn Gillmor <dkg@fifthhorseman.net>]

[-- Attachment #1.1: Type: text/plain, Size: 1317 bytes --]

On Sun 2022-09-11 23:50:18 +0200, Justus Winter wrote:
> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>> On Fri, Sep 09 2022, Justus Winter wrote:
>>
>>> ---
>>>  test/T350-crypto.sh | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh
>>> index 3c6626b4..721cbfdd 100755
>>> --- a/test/T350-crypto.sh
>>> +++ b/test/T350-crypto.sh
>>> @@ -467,7 +467,7 @@ expected='[[[{"id": "XXXXX",
>>>   "Date": "Sat, 01 Jan 2000 12:00:00 +0000"},
>>>   "body": [{"id": 1,
>>>   "sigstatus": [{"status": "error",
>>> - "keyid": "6D92612D94E46381",
>>> + "keyid": "'$(echo $FINGERPRINT | cut -c 25-)'",
>>
>> The "bashism" (works also in zsh) ${FINGERPRINT:24} works here
>> (and has been used in other lines in this file
>
> Interesting.  FTR, I saw this method being used elsewhere and simply
> copied it.  If that'd prevent merging the change, I'd actually prefer
> introducing a variable KEYID that is set explicitly in the test library.
> The reason for that is that in v5 OpenPGP, the keyid will be computed
> differently.

I don't think this should prevent merging the change -- Tomi is just
offering an efficiency improvement.

i'd also be happy with the introduction of an explicitly-set KEYID
variable.  These could be distinct changes.

           --dkg

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]