From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id CO82BMohJGTqDwEASxT56A (envelope-from ) for ; Wed, 29 Mar 2023 13:32:26 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id 8Cg0A8ohJGQcpAAAG6o9tA (envelope-from ) for ; Wed, 29 Mar 2023 13:32:26 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6864D21EAE for ; Wed, 29 Mar 2023 13:32:25 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id C77B95F800; Wed, 29 Mar 2023 11:32:22 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 0D1CB5F7E6 for ; Wed, 29 Mar 2023 11:32:19 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 0AB675FB82; Wed, 29 Mar 2023 07:32:18 -0400 (EDT) Received: (nullmailer pid 2531620 invoked by uid 1000); Wed, 29 Mar 2023 11:32:16 -0000 From: David Bremner To: Kevin Boulain Subject: Re: [PATCH 2/2] lib/message-property: sync removed properties to the database In-Reply-To: <87jzzyycmt.fsf@boula.in> References: <20230301205149.297637-1-kevin@boula.in> <20230301205149.297637-2-kevin@boula.in> <87jzzyycmt.fsf@boula.in> Date: Wed, 29 Mar 2023 08:32:16 -0300 Message-ID: <87v8ij6ben.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 35IXQ7HA7HRSKOM442PCVQY6IILGMH2N X-Message-ID-Hash: 35IXQ7HA7HRSKOM442PCVQY6IILGMH2N X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: notmuch@notmuchmail.org X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680089545; a=rsa-sha256; cv=none; b=OQ6q5DMFUb7yMFKUws9uqQCFY3UmPhua1EWX9nqnWYqojl5t7Y+LPjY8VlTpV5mk/odo7E gxQR4gPYRi3GQ1PPTRh1wcwI3aYCMHrNToVtAMAoRV+AqMKTwvqxWnCZjWa4odn40ET3IM f3yApVwYR6PCRC73KJZKiPCCw3iyGTVRWgRePUAQEaV7XgZtaGWmKNUCQzje8nS0+0XjVC a/eQrPUsdJvBbTwxJroAOVjs5D0fDN0U2gFWkVVj6VP+pSiAUJVtKB2XWHEwFa5VH/8LJ9 6aO/iqLyzp0o0Pu7E/6RXR23Bf3aovKTUMmwT5xi5yRM1PuP3GBxqbG6Ajo45Q== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680089545; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=cjn4JL/W2pU2QvMgCDsFoi5pMhMnSBBbqnjZZjtk8BA=; b=VtG/KUgZiXxITF3lDrbUlQxfn9IESbg0wrmLGgXQMneAy+O46BhlbU0QuIbOIIcJS3kp4k cxeS8mG61AnNP/SsCjjERwRw90kz3lMc0xmjokcUCTnp9SxEPC0AZpQRnFeZeUqOvrQHA4 ClTRJ/YcoePnubxkLdJNnxnBP/l4x6vbUPyRg5kJS8IbBhVyGJLGEBjGy4MK+xoCq0XqQ+ 1ocUv0JQhCg1ML9zgMbLiPNU8Jal5IAvkq6VsPF0fX5v9zpxEkKeqr8V4oAhbeaGC8Ud+S Y0j0zWysJv3SqbnLF550+n4716y0+k1MKM8Mn4dyYmbfOzkHC586L44W5io3OQ== X-Migadu-Spam-Score: -1.93 X-Spam-Score: -1.93 X-Migadu-Queue-Id: 6864D21EAE X-Migadu-Scanner: scn0.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-TUID: p9w8gDg7MRfo Kevin Boulain writes: > On 2023-03-03 at 00:39 +02, Tomi Ollila wrote: >> Somehow testkey1 = testvalue1 disappeared from the test code (which is >> probably expected -- perhaps the commit message of the *change* 1/2 >> tried to point to that ;D) > > Yes, that proves notmuch_message_remove_all_properties is broken without > the patch. The eponymous test gave the impression the property had been > removed (stdout is empty) but I believe this is only due to > _notmuch_message_invalidate_metadata. Now the "dump message properties" > test doesn't list it anymore, which is what I expect. It would be nice to structure this in terms of a known broken test (perhaps modify the existing one to reopen the database and dump the properties) that is then fixed by patch adding the sync.