From: David Bremner <david@tethera.net>
To: Kevin Boulain <kevin@boula.in>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] lib/message-property: sync removed properties to the database
Date: Wed, 29 Mar 2023 08:32:16 -0300 [thread overview]
Message-ID: <87v8ij6ben.fsf@tethera.net> (raw)
In-Reply-To: <87jzzyycmt.fsf@boula.in>
Kevin Boulain <kevin@boula.in> writes:
> On 2023-03-03 at 00:39 +02, Tomi Ollila <tomi.ollila@iki.fi> wrote:
>> Somehow testkey1 = testvalue1 disappeared from the test code (which is
>> probably expected -- perhaps the commit message of the *change* 1/2
>> tried to point to that ;D)
>
> Yes, that proves notmuch_message_remove_all_properties is broken without
> the patch. The eponymous test gave the impression the property had been
> removed (stdout is empty) but I believe this is only due to
> _notmuch_message_invalidate_metadata. Now the "dump message properties"
> test doesn't list it anymore, which is what I expect.
It would be nice to structure this in terms of a known broken test
(perhaps modify the existing one to reopen the database and dump the properties)
that is then fixed by patch adding the sync.
next prev parent reply other threads:[~2023-03-29 11:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 20:51 [PATCH 1/2] test: display key name in property tests Kevin Boulain
2023-03-01 20:51 ` [PATCH 2/2] lib/message-property: sync removed properties to the database Kevin Boulain
2023-03-02 22:39 ` Tomi Ollila
2023-03-02 23:08 ` Kevin Boulain
2023-03-29 11:32 ` David Bremner [this message]
2023-03-29 16:13 ` [PATCH v2 1/5] test: display key name in property tests Kevin Boulain
2023-03-29 16:13 ` [PATCH v2 2/5] test: remove unnecessary sorting Kevin Boulain
2023-03-29 16:13 ` [PATCH v2 3/5] test: reorganize tests and mark a few of them as broken Kevin Boulain
2023-03-29 16:13 ` [PATCH v2 4/5] lib/message-property: sync removed properties to the database Kevin Boulain
2023-03-29 16:13 ` [PATCH v2 5/5] test: add test for notmuch_message_remove_all_properties_with_prefix Kevin Boulain
2023-03-30 11:25 ` David Bremner
2023-03-29 16:23 ` [PATCH 2/2] lib/message-property: sync removed properties to the database Kevin Boulain
2023-03-29 11:33 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8ij6ben.fsf@tethera.net \
--to=david@tethera.net \
--cc=kevin@boula.in \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).