unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Carl Worth <cworth@cworth.org>
To: Ben Gamari <bgamari.foss@gmail.com>, notmuch <notmuch@notmuchmail.org>
Subject: Re: [PATCH] notmuch-config: make new message tags configurable
Date: Fri, 23 Apr 2010 10:40:50 -0700	[thread overview]
Message-ID: <87tyr2f4nx.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <1268432006-24333-2-git-send-email-bgamari.foss@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1851 bytes --]

On Fri, 12 Mar 2010 17:13:26 -0500, Ben Gamari <bgamari.foss@gmail.com> wrote:
> Add a new_tags option in the [messages] section of the configuration
> file to allow the user to specify which tags should be added to new
> messages by notmuch new.

Thanks, Ben!

I finally broke down and decided I needed this feature.

Previously I've done all of my automatic tagging as global searches,
(and it's those tags that I want to switch to just search macros as I've
talked about many times in the past).

But I'm now doing things like a "merge window" tag where I want it
applied to new messages as they come in, but I also want to be able to
manually remove the tag from messages where it doesn't make sense. So a
global search doesn't do what I want here at all.

For me, I'll probably go the route of having "notmuch new" add a "new"
tag in addition to "inbox" and "unread" and then I'll have my
notmuch-poll script act on that, then remove the "new" tag from all
tagged messages. I wouldn't want to impose a "new" tag on everyone since
most people won't have a notmuch-poll removing "new" by default so that
tag would just build up.

Meanwhile, I know that Keith Packard and Eric Anholt are already having
their notmuch-poll scripts remove the "unread" tag from all message,
since they don't find that tag useful at all. This new configuration
will help them as well.

So I've now merged this patch, and as usual, I followed up with some
changes as well. Here's what I did in addition:

  * Fixed the compiler warning.

  * Fixed "notmuch setup" to add the documentation block to the
    configuration file when adding new options there.

  * Renamed the new configuration option from:

	[messages]
	new_tags=inbox;unread;

    to instead be:

	[new]
	tags=inbox;unread;

  * Fixed "notmuch setup" to prompt for this new setting.

Thanks again,

-Carl

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

      parent reply	other threads:[~2010-04-23 17:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-12 22:13 [PATCH] Configurable tags for notmuch new Ben Gamari
2010-03-12 22:13 ` [PATCH] notmuch-config: make new message tags configurable Ben Gamari
2010-03-28  2:28   ` Ben Gamari
2010-03-28  5:57     ` Michal Sojka
2010-03-28 14:42       ` Ben Gamari
2010-03-29  7:35         ` Michal Sojka
2010-03-29  7:43   ` Sebastian Spaeth
2010-04-23 17:40   ` Carl Worth [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tyr2f4nx.fsf@yoom.home.cworth.org \
    --to=cworth@cworth.org \
    --cc=bgamari.foss@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).