From: Carl Worth <cworth@cworth.org>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] test: use `princ' instead of `message' calls in emacs tests
Date: Fri, 27 May 2011 16:12:20 -0700 [thread overview]
Message-ID: <87tycfrb57.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <1305008708-15610-1-git-send-email-dmitry.kurochkin@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 934 bytes --]
On Tue, 10 May 2011 10:25:08 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> The patch replaces all (message (buffer-string)) calls in emacs
> tests with (princ (buffer-string)). This avoids accidentally
> interpreting '%' as format specifiers and makes code simpler
> because we do not need to capture stderr.
>
> Also, the patch works around an Emacs (23.3+1-1 on current Debian
> Unstable) segfault in "Ensure that emacs doesn't drop results"
> test.
Thanks so much for the fix! I hadn't noticed the segfault until the
recent additional include of test-lib.el, (which of course shouldn't
actually be changing anything), which seems to tickle the emacs bug a
little more frequently for me at least.
The segfault made it obvious that this was an emacs bug, but it was
annoying to hit. It will be nice to have this fix in place.
This change is pushed now.
-Carl
--
carl.d.worth@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
prev parent reply other threads:[~2011-05-27 23:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-10 6:25 [PATCH] test: use `princ' instead of `message' calls in emacs tests Dmitry Kurochkin
2011-05-10 9:12 ` Jameson Graef Rollins
2011-05-27 23:12 ` Carl Worth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tycfrb57.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).