From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 376F2431FB6 for ; Thu, 26 Jan 2012 08:19:01 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ptKEqi1X7WiE for ; Thu, 26 Jan 2012 08:19:00 -0800 (PST) Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 57CEB431FAE for ; Thu, 26 Jan 2012 08:19:00 -0800 (PST) Received: by bkbzt19 with SMTP id zt19so692127bkb.26 for ; Thu, 26 Jan 2012 08:18:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=4z8jf2u62haylsHcH8JKVLsfENc3bpPEPBtUZXSnIRQ=; b=OYqrgeIvJsnwlY52uZNnGR2o/q7R4Z+UBefVhxMhqt/E1GyBaVsFlmIxfuz7TlHNd9 0jE1WcO1WtGWggZwbZUr3m7ATHGaLuKOtkiHBOidW6bBqBD6tfrkkCXnN1jASm1cwnjQ YrJVM3VzB79Sc3PuIy9FBDFGC3F4+1hdB8O6Y= Received: by 10.205.132.1 with SMTP id hs1mr939505bkc.45.1327594737597; Thu, 26 Jan 2012 08:18:57 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id ew13sm9999244bkb.1.2012.01.26.08.18.56 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 26 Jan 2012 08:18:56 -0800 (PST) From: Dmitry Kurochkin To: David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH 0/2] re-enable line wrapping and add some header bling In-Reply-To: <1327565871-19729-1-git-send-email-dme@dme.org> References: <1327565871-19729-1-git-send-email-dme@dme.org> User-Agent: Notmuch/0.11+116~ge6e10b8 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Thu, 26 Jan 2012 20:17:49 +0400 Message-ID: <87ty3iqvyq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jan 2012 16:19:01 -0000 Hi David. On Thu, 26 Jan 2012 08:17:49 +0000, David Edmondson wrote: > By default, re-enable `visual-line-mode' in `notmuch-show-mode'. Do it > via a hook so that purists (ahem) can turn it off. > > Add some more processing of headers to make them look nice. Do it via > hooks so that unbelievers can turn it off. > I did not review the code, but here is a general comment for both patches (but especially for the first one). It would be nice to have a more detailed documentation for hooks. Docstring like "Enable Visual Line mode." for a function named `notmuch-show-turn-on-visual-line-mode' is near useless. It is quite obvious that the function enables visual-line-mode from it's name. And it does not give any information on why would someone actually want to use it. I do not remember what visual-line-mode is exactly, so to understand whether this hook is actually useful for me, I have to read visual-line-mode docs, think about how it helps in notmuch-show, read some code, perhaps, etc. I would argue that since the hook itself is trivial, the main point in having it is to provide a clearly documented solution for a common problem for those who do not know how to solve this problem right away. Currently, those who know what visual-line-mode is do not need this hook, because they can easily write their own, and those who do not know what visual-line-mode is can not use this hook, because it says nothing about why it is actually useful. Also, in addition to better docs, I would rename `notmuch-show-turn-on-visual-line-mode' to something that reflects what it does from user POV (like the other two hooks). Though, the fact that the hook is enabled by default makes the above arguments less important, I guess. Regards, Dmitry > David Edmondson (2): > emacs: Re-enable line wrapping in `notmuch-show-mode'. > emacs: Add more processing of displayed headers. > > emacs/notmuch-show.el | 50 +++++++++++++++++++++++++++++++++++++++++------- > 1 files changed, 42 insertions(+), 8 deletions(-) > > -- > 1.7.8.3 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch