From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/2] re-enable line wrapping and add some header bling
Date: Thu, 26 Jan 2012 20:17:49 +0400 [thread overview]
Message-ID: <87ty3iqvyq.fsf@gmail.com> (raw)
In-Reply-To: <1327565871-19729-1-git-send-email-dme@dme.org>
Hi David.
On Thu, 26 Jan 2012 08:17:49 +0000, David Edmondson <dme@dme.org> wrote:
> By default, re-enable `visual-line-mode' in `notmuch-show-mode'. Do it
> via a hook so that purists (ahem) can turn it off.
>
> Add some more processing of headers to make them look nice. Do it via
> hooks so that unbelievers can turn it off.
>
I did not review the code, but here is a general comment for both
patches (but especially for the first one). It would be nice to have a
more detailed documentation for hooks. Docstring like "Enable Visual
Line mode." for a function named `notmuch-show-turn-on-visual-line-mode'
is near useless. It is quite obvious that the function enables
visual-line-mode from it's name. And it does not give any information
on why would someone actually want to use it. I do not remember what
visual-line-mode is exactly, so to understand whether this hook is
actually useful for me, I have to read visual-line-mode docs, think
about how it helps in notmuch-show, read some code, perhaps, etc. I
would argue that since the hook itself is trivial, the main point in
having it is to provide a clearly documented solution for a common
problem for those who do not know how to solve this problem right away.
Currently, those who know what visual-line-mode is do not need this
hook, because they can easily write their own, and those who do not know
what visual-line-mode is can not use this hook, because it says nothing
about why it is actually useful.
Also, in addition to better docs, I would rename
`notmuch-show-turn-on-visual-line-mode' to something that reflects what
it does from user POV (like the other two hooks).
Though, the fact that the hook is enabled by default makes the above
arguments less important, I guess.
Regards,
Dmitry
> David Edmondson (2):
> emacs: Re-enable line wrapping in `notmuch-show-mode'.
> emacs: Add more processing of displayed headers.
>
> emacs/notmuch-show.el | 50 +++++++++++++++++++++++++++++++++++++++++-------
> 1 files changed, 42 insertions(+), 8 deletions(-)
>
> --
> 1.7.8.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2012-01-26 16:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-26 8:17 [PATCH 0/2] re-enable line wrapping and add some header bling David Edmondson
2012-01-26 8:17 ` [PATCH 1/2] emacs: Re-enable line wrapping in `notmuch-show-mode' David Edmondson
2012-01-26 20:26 ` Tomi Ollila
2012-01-27 11:57 ` David Bremner
2012-01-26 8:17 ` [PATCH 2/2] emacs: Add more processing of displayed headers David Edmondson
2012-01-26 16:17 ` Dmitry Kurochkin [this message]
2012-01-27 6:52 ` [PATCH 0/2] re-enable line wrapping and add some header bling David Edmondson
2012-01-27 8:22 ` Jani Nikula
2012-01-26 17:36 ` Jani Nikula
2012-02-06 13:16 ` [PATCH v2] Wrap and indent headers in show mode David Edmondson
2012-02-06 13:16 ` [PATCH v2] emacs: Add more processing of displayed headers David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ty3iqvyq.fsf@gmail.com \
--to=dmitry.kurochkin@gmail.com \
--cc=dme@dme.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).