From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 15906431FB6 for ; Sat, 28 Jan 2012 01:50:42 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bg++2gGWqGFi for ; Sat, 28 Jan 2012 01:50:38 -0800 (PST) Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id EAAF5431FAE for ; Sat, 28 Jan 2012 01:50:37 -0800 (PST) Received: by bkbzt19 with SMTP id zt19so2384438bkb.26 for ; Sat, 28 Jan 2012 01:50:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=tp69KnoQYVYlTdiwQp8i76mXUPK33h48+NEFE8hSlJA=; b=hPzgB7dESbplhIp1Nyj4U7r+36ZMZyA7Q2cfsnb6s1DVgRVu14eMoChFqYtI76BHxd FaRmYRDxIo64ZISocaluPVq0y8eHg3yELmshvQurcnd27kqA5yZbppID9cwr8R/Zsof5 EAeCwAY0wT+gq5ciTJd4kDNzGeC6ey9SwHHZI= Received: by 10.204.129.220 with SMTP id p28mr4884693bks.8.1327744236644; Sat, 28 Jan 2012 01:50:36 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id cg2sm22178901bkb.12.2012.01.28.01.50.35 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 28 Jan 2012 01:50:35 -0800 (PST) From: Dmitry Kurochkin To: Jani Nikula Subject: Re: [PATCH 7/6] emacs: relax tag syntax check in `notmuch-tag' function In-Reply-To: References: <1327725684-5887-1-git-send-email-dmitry.kurochkin@gmail.com> <1327727143-24455-1-git-send-email-dmitry.kurochkin@gmail.com> User-Agent: Notmuch/0.11+134~g7ddba9d (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sat, 28 Jan 2012 13:49:27 +0400 Message-ID: <87ty3g88d4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Jan 2012 09:50:42 -0000 On Sat, 28 Jan 2012 10:56:21 +0200, Jani Nikula wrote: > On Jan 28, 2012 7:06 AM, "Dmitry Kurochkin" > wrote: > > > > The tag syntax check in `notmuch-tag' function was too strict and did > > not allow nmbug tags with "::". Since the check is done for all > > tagging operations in Emacs UI, this basically means that no nmbug > > tags can be changed. The patch relaxes the tag syntax check to allow > > any tag names that do not include whitespace characters. > > Imho the syntax check should be in cli, or lib even. I posted a patch to > cli some time ago when I realized it's possible to add tag "-" but you > can't remove it with the current cli. (On the road, can't find the message > id now.) > I agree that this is an issue (a general issue for notmuch, not just Emacs UI). But it is outside of scope of this patch. This patch purpose is just to solve an immediate issue with a broken regexp. Regards, Dmitry > > --- > > emacs/notmuch.el | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/emacs/notmuch.el b/emacs/notmuch.el > > index 9813e0a..0de6123 100644 > > --- a/emacs/notmuch.el > > +++ b/emacs/notmuch.el > > @@ -555,7 +555,7 @@ notmuch-after-tag-hook will be run." > > ;; Perform some validation > > (when (null tags) (error "No tags given")) > > (mapc (lambda (tag) > > - (unless (string-match-p "^[-+][-+_.[:word:]]+$" tag) > > + (unless (string-match-p "^[-+]\\S-+$" tag) > > (error "Tag must be of the form `+this_tag' or `-that_tag'"))) > > tags) > > (run-hooks 'notmuch-before-tag-hook) > > -- > > 1.7.8.3 > > > > _______________________________________________ > > notmuch mailing list > > notmuch@notmuchmail.org > > http://notmuchmail.org/mailman/listinfo/notmuch Non-text part: text/html