From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] contrib: add notmuch-pick.el file itself
Date: Sat, 27 Oct 2012 13:39:04 -0400 [thread overview]
Message-ID: <87txtfhl1j.fsf@betacantrips.com> (raw)
In-Reply-To: <1351337200-18050-2-git-send-email-markwalters1009@gmail.com>
Mark Walters <markwalters1009@gmail.com> writes:
> +(defvar notmuch-pick-json-parser nil
> + "Incremental JSON parser for the search process filter.")
> +
> +(defun notmuch-pick-process-filter (proc string)
> + "Process and filter the output of \"notmuch show\" (for pick)"
> + (let ((results-buf (process-buffer proc))
> + (parse-buf (process-get proc 'parse-buf))
> + (inhibit-read-only t)
> + done)
> + (if (not (buffer-live-p results-buf))
> + (delete-process proc)
> + (with-current-buffer parse-buf
> + ;; Insert new data
> + (save-excursion
> + (goto-char (point-max))
> + (insert string)))
> + (with-current-buffer results-buf
> + (save-excursion
> + (goto-char (point-max))
> + (while (not done)
> + (condition-case nil
> + (case notmuch-pick-process-state
This looks awfully familiar. Not looking too close, but why can't this
re-use the JSON parser from your other patch? Just not to rely on the
other patch series?
Still, let's get this pushed.
Ethan
next prev parent reply other threads:[~2012-10-27 17:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 11:26 [PATCH 0/3] Add notmuch-pick to contrib Mark Walters
2012-10-27 11:26 ` [PATCH 1/3] contrib: add notmuch-pick.el file itself Mark Walters
2012-10-27 17:39 ` Ethan Glasser-Camp [this message]
2012-10-27 17:49 ` Mark Walters
2012-10-27 11:26 ` [PATCH 2/3] contrib: add pick README Mark Walters
2012-10-27 12:55 ` Eirik Byrkjeflot Anonsen
2012-10-27 13:38 ` [PATCH v2] " Mark Walters
2012-10-27 11:26 ` [PATCH 3/3] contrib: add pick TODO file Mark Walters
2012-10-27 12:13 ` [PATCH 0/3] Add notmuch-pick to contrib Tomi Ollila
2012-10-28 15:16 ` David Bremner
2012-10-29 8:28 ` Mark Walters
2012-12-01 21:03 ` Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txtfhl1j.fsf@betacantrips.com \
--to=ethan.glasser.camp@gmail.com \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).