From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: Xapian-quoting based batch-tagging.
Date: Wed, 26 Dec 2012 09:23:00 -0400 [thread overview]
Message-ID: <87txr9q763.fsf@zancas.localnet> (raw)
In-Reply-To: <87ehid5h64.fsf@qmul.ac.uk>
Mark Walters <markwalters1009@gmail.com> writes:
> I am unclear about how this is going to deal with queries containing
> newlines. For dump/restore I think this is not a problem (as Austin and
> others have said), but for batch tagging I think it could be; for
> example the query could be for a tag containing a newline.
Yes, that's true, this patch series does not support queries with tags
with embedded newlines. They can still be removed (and added) via either
batch tagging or the command line. We could just live with this, or
- The current syntax allows for detecting options at the start of the
line; perhaps a future fix would be to have the batch tagging and
command line tagging accept an optionally hex encoded query, something
like:
--hex +found%20it -- tag:%22stupid%0Atag%22
- Alternatively, we could add hex decoding on top of xapian quoting for
queries. One UI downside is that people have to remember that % are
special.
+found%25it -- tag:lost%25it
Another is that quoting is still (surprisingly) necessary for encoded
spaces
+found%20it -- tag:"lost%20it"
Introducing yet another escape format, e.g. "\n" would require more
code, and not really much benefit afaict versus re-using hex-encoding.
Offhand I don't see how to avoid this without some level of query
pre-processing a-la
id:1356313183-9266-1-git-send-email-david@tethera.net
d
next prev parent reply other threads:[~2012-12-26 13:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-25 19:42 Xapian-quoting based batch-tagging david
2012-12-25 19:42 ` [PATCH 01/11] parse_tag_line: use enum for return value david
2012-12-26 13:48 ` David Bremner
2012-12-25 19:42 ` [PATCH 02/11] tag-util: factor out rules for illegal tags, use in parse_tag_line david
2012-12-25 19:42 ` [PATCH 03/11] notmuch-tag.c: convert to use tag-utils david
2012-12-25 19:42 ` [PATCH 04/11] cli: add support for batch tagging operations to "notmuch tag" david
2013-01-03 18:42 ` Jani Nikula
2012-12-25 19:42 ` [PATCH 05/11] test/tagging: add test for error messages of tag --batch david
2012-12-25 19:42 ` [PATCH 06/11] test/tagging: add basic tests for batch tagging functionality david
2012-12-25 19:42 ` [PATCH 07/11] test/tagging: add tests for exotic tags david
2012-12-25 19:42 ` [PATCH 08/11] test/tagging: add test for exotic message-ids and batch tagging david
2012-12-25 19:42 ` [PATCH 09/11] notmuch-tag.1: tidy synopsis formatting, reference david
2012-12-26 13:48 ` David Bremner
2012-12-25 19:42 ` [PATCH 10/11] man: document notmuch tag --batch, --input options david
2012-12-25 19:42 ` [PATCH 11/11] test/tagging: add test for naked punctuation in tags; compare with quoting spaces david
2012-12-26 8:52 ` Xapian-quoting based batch-tagging Mark Walters
2012-12-26 13:23 ` David Bremner [this message]
2013-01-03 19:41 ` Jani Nikula
2013-01-04 5:32 ` Jameson Graef Rollins
2013-01-03 19:59 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txr9q763.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).