From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id C6BC4431FAE for ; Sat, 20 Jul 2013 05:36:53 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Xa60ECorVr+O for ; Sat, 20 Jul 2013 05:36:46 -0700 (PDT) Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 14A79431FAF for ; Sat, 20 Jul 2013 05:36:46 -0700 (PDT) Received: from remotemail by yantan.tethera.net with local (Exim 4.80) (envelope-from ) id 1V0WOy-0002nc-OY; Sat, 20 Jul 2013 09:36:44 -0300 Received: (nullmailer pid 23582 invoked by uid 1000); Sat, 20 Jul 2013 12:36:41 -0000 From: David Bremner To: Jameson Graef Rollins , Notmuch Mail Subject: Re: [PATCH] crypto: return NULL cryptoctx if protocol string is empty. In-Reply-To: <1374248172-14199-1-git-send-email-jrollins@finestructure.net> References: <1374248172-14199-1-git-send-email-jrollins@finestructure.net> User-Agent: Notmuch/0.15.2+223~g3484372 (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sat, 20 Jul 2013 09:36:41 -0300 Message-ID: <87txjpe7c6.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 Jul 2013 12:36:53 -0000 Jameson Graef Rollins writes: > Badly formed messages that don't specify a protocol in > signed/encrypted parts, end up with a protocol of NULL. strcasecmp in > notmuch_crypto_get_context then segfaults when trying to check it > against known protocols. If the protocol is NULL, just return an > empty context immediately (with appropriate message.) Pushed, thanks for the fix d