unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] crypto: return NULL cryptoctx if protocol string is empty.
Date: Sat, 20 Jul 2013 09:36:41 -0300	[thread overview]
Message-ID: <87txjpe7c6.fsf@zancas.localnet> (raw)
In-Reply-To: <1374248172-14199-1-git-send-email-jrollins@finestructure.net>

Jameson Graef Rollins <jrollins@finestructure.net> writes:

> Badly formed messages that don't specify a protocol in
> signed/encrypted parts, end up with a protocol of NULL.  strcasecmp in
> notmuch_crypto_get_context then segfaults when trying to check it
> against known protocols.  If the protocol is NULL, just return an
> empty context immediately (with appropriate message.)

Pushed, thanks for the fix

d

      parent reply	other threads:[~2013-07-20 12:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <id:51E95500.8000404@fifthhorseman.net>
2013-07-19 15:36 ` [PATCH] crypto: return NULL cryptoctx if protocol string is empty Jameson Graef Rollins
2013-07-19 15:57   ` Jameson Graef Rollins
2013-07-20 12:36   ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txjpe7c6.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=jrollins@finestructure.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).