unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/3] General fixes
Date: Thu, 10 Oct 2013 08:02:19 -0300	[thread overview]
Message-ID: <87txgpv16s.fsf@zancas.localnet> (raw)
In-Reply-To: <1380558523-6913-1-git-send-email-felipe.contreras@gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> writes:

> Felipe Contreras (3):
>   query: bind queries to database objects
>   ruby: allow build with RUNPATH
>   ruby: bind database close()/destroy() properly

Hi Felipe;

I agree with the discussion on IRC that the change in the first patch
makes sense.

It would be nice to have a bit more explanation in the commit message of
the second message; at least to point out that (iiuc) this is not a
really a ruby specific thing, just a standard ld.so feature.

d

  parent reply	other threads:[~2013-10-10 11:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-30 16:28 [PATCH 0/3] General fixes Felipe Contreras
2013-09-30 16:28 ` [PATCH 1/3] query: bind queries to database objects Felipe Contreras
2013-09-30 16:28 ` [PATCH 2/3] ruby: allow build with RUNPATH Felipe Contreras
2013-09-30 16:28 ` [PATCH 3/3] ruby: bind database close()/destroy() properly Felipe Contreras
2013-10-10 11:02 ` David Bremner [this message]
2013-10-15  5:25   ` [PATCH 0/3] General fixes Felipe Contreras
2013-11-02 12:17   ` Felipe Contreras
2013-11-02 13:18     ` David Bremner
2013-11-02 13:22       ` Felipe Contreras
2013-11-02 13:39         ` Tomi Ollila

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87txgpv16s.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=felipe.contreras@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).