From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/7] emacs: tag: allow default case in notmuch-tag-formats
Date: Mon, 10 Feb 2014 13:19:01 -0500 [thread overview]
Message-ID: <87txc6n84q.fsf@awakening.csail.mit.edu> (raw)
In-Reply-To: <1390087855-26194-3-git-send-email-markwalters1009@gmail.com>
On Sat, 18 Jan 2014, Mark Walters <markwalters1009@gmail.com> wrote:
> Allow an empty string in notmuch-tag-formats which matches all tags
> except those matched explicitly matched. This allows the user to tell
Typo.
> notmuch to hide all tags except those specified.
>
> This will be useful once formatting for deleted/added tags is added
> later in the series: a user might want to hide all deleted tags for
> example.
> ---
> emacs/notmuch-tag.el | 20 +++++++++++---------
> 1 files changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
> index 2153068..92c1249 100644
> --- a/emacs/notmuch-tag.el
> +++ b/emacs/notmuch-tag.el
> @@ -65,14 +65,15 @@
> This gives a list that maps from tag names to lists of formatting
> expressions. The car of each element gives a tag name and the
> cdr gives a list of Elisp expressions that modify the tag. If
> -the list is empty, the tag will simply be hidden. Otherwise,
> -each expression will be evaluated in order: for the first
> -expression, the variable `tag' will be bound to the tag name; for
> -each later expression, the variable `tag' will be bound to the
> -result of the previous expression. In this way, each expression
> -can build on the formatting performed by the previous expression.
> -The result of the last expression will displayed in place of the
> -tag.
> +the car is an empty string it matches all tags that do not have
> +an explicit match. If the list is empty, the tag will simply be
Hmm. I'm not sure I like overloading of the meanings of strings. Could
we instead use a symbol to represent this case? For example, `t' would
parallel the fall-through case of `cond' and `case', or `_' would
parallel `pcase' [1]. Or even a separate variable like
notmuch-tag-default-format?
The former would require some tweaking of the customize widget, but that
should probably happen anyway to support this special case.
Unfortunately, we may need a custom alist widget variant to do that. (I
tried and failed to tweak it in a way that both worked and looked
decent.) Hence my suggestion of a separate variable, which would only
require pulling out the :value-type into its own define-widget.
I'm also slightly bothered that this would introduce a second way to
control the default formatting of tags in addition to notmuch-tag-face,
but only slightly.
[1] It's unfortunate that pcase wasn't introduced until Emacs 24. I've
been tempted to backport it for notmuch multiple times now. Then we
could just treat notmuch-tag-formats as a list of pcase conditions.
> +hidden. Otherwise, each expression will be evaluated in order:
> +for the first expression, the variable `tag' will be bound to the
> +tag name; for each later expression, the variable `tag' will be
> +bound to the result of the previous expression. In this way,
> +each expression can build on the formatting performed by the
> +previous expression. The result of the last expression will
> +displayed in place of the tag.
>
> For example, to replace a tag with another string, simply use
> that string as a formatting expression. To change the foreground
> @@ -140,7 +141,8 @@ This can be used with `notmuch-tag-format-image-data'."
>
> (defun notmuch-tag-format-tag (tag)
> "Format TAG by looking into `notmuch-tag-formats'."
> - (let ((formats (assoc tag notmuch-tag-formats)))
> + (let ((formats (or (assoc tag notmuch-tag-formats)
> + (assoc "" notmuch-tag-formats))))
> (cond
> ((null formats) ;; - Tag not in `notmuch-tag-formats',
> tag) ;; the format is the tag itself.
> --
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2014-02-10 18:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-18 23:30 [PATCH 0/7] emacs: show tag changes in buffer Mark Walters
2014-01-18 23:30 ` [PATCH 1/7] emacs: tag split customise option for format-tags into a widget Mark Walters
2014-01-18 23:30 ` [PATCH 2/7] emacs: tag: allow default case in notmuch-tag-formats Mark Walters
2014-02-10 18:19 ` Austin Clements [this message]
2014-02-11 10:23 ` Mark Walters
2014-02-11 22:57 ` Austin Clements
2014-02-12 17:32 ` [WIP PATCH] Make keys of notmuch-tag-formats regexps and use caching Austin Clements
2014-01-18 23:30 ` [PATCH 3/7] emacs: tag: add customize for deleted/added tag formats Mark Walters
2014-01-18 23:30 ` [PATCH 4/7] emacs: show: mark tags changed since buffer loaded Mark Walters
2014-02-12 1:21 ` Austin Clements
2014-01-18 23:30 ` [PATCH 5/7] emacs: show: use orig-tags for tag display Mark Walters
2014-01-18 23:30 ` [PATCH 6/7] emacs: search: use orig-tags in search Mark Walters
2014-02-12 1:30 ` Austin Clements
2014-01-18 23:30 ` [PATCH 7/7] emacs: tree: " Mark Walters
2014-01-25 19:35 ` [PATCH 0/7] emacs: show tag changes in buffer Jani Nikula
2014-02-05 22:25 ` Tomi Ollila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txc6n84q.fsf@awakening.csail.mit.edu \
--to=amdragon@mit.edu \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).