From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <david@tethera.net>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 8CB74431FBF
	for <notmuch@notmuchmail.org>; Tue, 25 Mar 2014 17:33:47 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id jF+3Ma952+Z7 for <notmuch@notmuchmail.org>;
	Tue, 25 Mar 2014 17:33:42 -0700 (PDT)
Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
	(using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
	(No client certificate requested)
	by olra.theworths.org (Postfix) with ESMTPS id CFC4C431FBD
	for <notmuch@notmuchmail.org>; Tue, 25 Mar 2014 17:33:42 -0700 (PDT)
Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
	(envelope-from <david@tethera.net>)
	id 1WSbml-0000ab-TV; Tue, 25 Mar 2014 21:33:39 -0300
Received: (nullmailer pid 32638 invoked by uid 1000); Wed, 26 Mar 2014
	00:33:36 -0000
From: David Bremner <david@tethera.net>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH] cli: Flush stdout before fork()ing to run hooks
In-Reply-To: <1395609746-26801-1-git-send-email-amdragon@mit.edu>
References: <1395609746-26801-1-git-send-email-amdragon@mit.edu>
User-Agent: Notmuch/0.17+150~g2743557 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-pc-linux-gnu)
Date: Tue, 25 Mar 2014 21:33:36 -0300
Message-ID: <87txalhk7z.fsf@zancas.localnet>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 26 Mar 2014 00:33:47 -0000

Austin Clements <amdragon@MIT.EDU> writes:

> Without this flush, if stdout is block buffered (which will happen if
> it's a pipe or a file, for example) and the hook also writes to
> stdout, then notmuch new's output will appear *after* the hook output.
>
> This situation may be a little esoteric, but it's good practice to
> flush before you fork anyway.

pushed.

d