From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 1559B431FBF for ; Sat, 29 Mar 2014 06:02:40 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.7 X-Spam-Level: X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fEWHg3C4ob4f for ; Sat, 29 Mar 2014 06:02:32 -0700 (PDT) Received: from mail-ee0-f43.google.com (mail-ee0-f43.google.com [74.125.83.43]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 81503431FBC for ; Sat, 29 Mar 2014 06:02:32 -0700 (PDT) Received: by mail-ee0-f43.google.com with SMTP id e53so4975083eek.2 for ; Sat, 29 Mar 2014 06:02:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:in-reply-to:references :user-agent:date:message-id:mime-version:content-type; bh=XyX+6Cg90OhUVSumzvcemY6E2QVLnKHBLZEXP12gY90=; b=CZdL9SGupMhiPQioGPRG3IVcOxgnhRRkDa7NuqfBtAEDyLDGK+ElkCkQrG4rmoXkGg qfJJPGKlCu9HK6M8v85YTXkGZE8YGmF/wd9U8lDMRemwo5/eGyD17cFjvm6t0GV80n6L swmZ/QxlGqA4mr0zmnuvh8HypM9xLqvuoC83v4fkgzxkNFWxWLFNEyZ/lnPiYu+BrY0q 9L7GedJ4qylaBJcxYcKKQ03M9BLYFwGs+e4ugNakvZyBVZykjADuRdqPuG1U/zlec8Qz Mhirc+tCUdb2hwgb6FHdFHSqRcWfewi+z63+z+aaMyTIpS6MInP5WzkYlZdt2pfIoyB8 9aPA== X-Gm-Message-State: ALoCoQlvwhVnqZnav5peWOwLsQq7N/Kp/rqX/w4wG2ipNM31mauhRJHxK1+80pQGdqDaa3xWpRNB X-Received: by 10.15.75.9 with SMTP id k9mr210170eey.110.1396098149835; Sat, 29 Mar 2014 06:02:29 -0700 (PDT) Received: from localhost (dsl-hkibrasgw2-58c36f-91.dhcp.inet.fi. [88.195.111.91]) by mx.google.com with ESMTPSA id w1sm18620674eel.16.2014.03.29.06.02.27 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 29 Mar 2014 06:02:28 -0700 (PDT) From: Jani Nikula To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] RFC: impliment gzipped output for notmuch dump In-Reply-To: <87ob0pdw84.fsf@zancas.localnet> References: <874n2kipq4.fsf@qmul.ac.uk> <1396056046-2247-1-git-send-email-david@tethera.net> <87wqfdbblz.fsf@nikula.org> <87ob0pdw84.fsf@zancas.localnet> User-Agent: Notmuch/0.17+164~gcd5fd5a4837e (http://notmuchmail.org) Emacs/24.3.1 (x86_64-pc-linux-gnu) Date: Sat, 29 Mar 2014 15:02:25 +0200 Message-ID: <87txahb1jy.fsf@nikula.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 29 Mar 2014 13:02:40 -0000 On Sat, 29 Mar 2014, David Bremner wrote: > Jani Nikula writes: > >> Is it reasonable to require zlib? It's possible to have conditional >> build for this, but it will be laborous to do it cleanly. I could be >> persuaded either way, perhaps more easily to just requiring it. > > If I recall correctly, xapian needs zlib. At least on Debian this is a > hard dependency. What is needed additionally is the zlib headers. Okay, no point in adding complexity in notmuch then. > I couldn't decide which was sillier: to have have gzipped output but not > input, or to leave off the command line argument (it's something like 3 > lines of diff). I lean to making it accessible from the CLI to better > support testing. Testability is a good point; otherwise we'd have to add an extra tool for testing the interface, which is also silly. If we don't add restore support now, I think we can consider this a documentation issue. One more thing: do we need to ensure we don't emit gzipped stuff to the terminal? BR, Jani.