From: Michal Sojka <sojkam1@fel.cvut.cz>
To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] cli: add --output=address-{from, to, all} to notmuch search
Date: Sat, 20 Sep 2014 10:04:08 +0200 [thread overview]
Message-ID: <87tx427m6f.fsf@steelpick.2x.cz> (raw)
In-Reply-To: <87k34zbcy3.fsf@maritornes.cs.unb.ca>
On Fri, Sep 19 2014, David Bremner wrote:
> Jani Nikula <jani@nikula.org> writes:
>
>> + if (name && *name)
>> + full_address = talloc_asprintf (NULL, "%s <%s>", name, addr);
>> + else
>> + full_address = talloc_asprintf (NULL, "<%s>", addr
>
> Is there some reason not to use sprinter as a talloc context here?
>
>> +
>> + if (!full_address)
>> + break;
>
> Is the error here out of memory? Maybe an error message would be a good
> idea.
>
>
> Obviously the docs need to be updated as well, and ideally the tests. I
> think Jani was hinting that he didn't want to be the person to do
> that. Any volunteers?
Yes, I'll look at that. It will probably take me a few days.
-Michal
next prev parent reply other threads:[~2014-09-20 8:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-06 12:53 [PATCH 1/3] cli: add support for parsing multiple keyword arguments Jani Nikula
2014-09-06 12:53 ` [PATCH 2/3] cli: add --output=address-{from, to, all} to notmuch search Jani Nikula
2014-09-06 13:35 ` Mark Walters
2014-09-06 16:41 ` [PATCH] cli: add --output=address-{from,to,all} " Jani Nikula
2014-09-06 16:47 ` [PATCH] cli: add --output=address-{from, to, all} " Jani Nikula
2014-09-06 17:47 ` Mark Walters
2014-09-19 19:57 ` [PATCH] cli: add --output=address-{from,to,all} " David Bremner
2014-09-20 8:04 ` Michal Sojka [this message]
2014-09-06 12:53 ` [PATCH 3/3] cli: deduplicate addresses for --output=address-* Jani Nikula
2014-09-19 19:27 ` [PATCH 1/3] cli: add support for parsing multiple keyword arguments David Bremner
-- strict thread matches above, loose matches on Subject: below --
2014-09-05 16:06 [PATCH v1 0/3] Address completion entirely in elisp David Edmondson
2014-09-06 8:14 ` [PATCH] cli: add --output=address-{from,to,all} to notmuch search Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tx427m6f.fsf@steelpick.2x.cz \
--to=sojkam1@fel.cvut.cz \
--cc=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).