From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: hello: fix accidental modification of widget-keymap
Date: Mon, 23 Nov 2015 08:46:04 -0400 [thread overview]
Message-ID: <87twoc51f7.fsf@zancas.localnet> (raw)
In-Reply-To: <1447326139-13620-1-git-send-email-markwalters1009@gmail.com>
Mark Walters <markwalters1009@gmail.com> writes:
> In emacs24 we use make-composed-keymap. It seems that if only a single
> map is specified then emacs just resuses it rather than creating a
> copy of it. Thus use make-sparse-keymap to force a copy.
> ---
>
> pseudomyne and the diredful author thamer found that we modify
> widget-keymap in notmuch. We clearly don't want to, and I think we
> tried not to, but emacs was being clever and reused the old keymap
> rather than creating a new one.
applied to release and master.
d
prev parent reply other threads:[~2015-11-23 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-12 11:02 [PATCH] emacs: hello: fix accidental modification of widget-keymap Mark Walters
2015-11-21 11:50 ` David Bremner
2015-11-23 12:46 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twoc51f7.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).