From: Jani Nikula <jani@nikula.org>
To: Damien Cassou <damien@cassou.me>,
David Bremner <david@tethera.net>,
notmuch@notmuchmail.org
Subject: Re: notmuch-reply doesn't use Reply-To
Date: Fri, 04 Dec 2015 19:14:39 +0200 [thread overview]
Message-ID: <87twnygmps.fsf@nikula.org> (raw)
In-Reply-To: <87fuzi9ng5.fsf@cassou.me>
On Fri, 04 Dec 2015, Damien Cassou <damien@cassou.me> wrote:
> David Bremner <david@tethera.net> writes:
>
>> Damien Cassou <damien@cassou.me> writes:
>>
>>> "To" : "rmod@inria.fr",
>>> "Reply-To" : "rmod@inria.fr",
>>> "From" : "seaside@rmod.inria.fr",
>>> "Subject" : "[rmod] [Mm10s] 2015-11-30",
>>> "Date" : "Mon, 30 Nov 2015 07:00:01 +0100"
>>
>> A quick look at the code suggests this is falling victim to the
>> "reply-to munging" detection code, which considers a reply-to field
>> redudant if it duplicates one of the other fields. From the source
>>
>> /* Some mailing lists munge the Reply-To header despite it being A Bad
>> * Thing, see http://www.unicom.com/pw/reply-to-harmful.html
>> *
>> * The munging is easy to detect, because it results in a
>> * redundant reply-to header, (with an address that already exists
>> * in either To or Cc). So in this case, we ignore the Reply-To
>> * field and use the From header. This ensures the original sender
>> * will get the reply even if not subscribed to the list. Note
>> * that the address in the Reply-To header will always appear in
>> * the reply.
>> */
>
>
> The last sentence seems to contradict my example:
>
> Note that the address in the Reply-To header will always appear in
> the reply.
>
> Here is the reply message, and it does not contain the address in Reply-To.
This was true way back when notmuch reply only knew about reply all. For
--reply-to=sender, it's broken. The simplest "fix" might be
diff --git a/notmuch-reply.c b/notmuch-reply.c
index 6df54fc992bb..ed0f9cca5c00 100644
--- a/notmuch-reply.c
+++ b/notmuch-reply.c
@@ -334,7 +334,7 @@ add_recipients_from_message (GMimeMessage *reply,
* that the address in the Reply-To header will always appear in
* the reply.
*/
- if (reply_to_header_is_redundant (message)) {
+ if (reply_to_header_is_redundant (message) && reply_all) {
reply_to_map[0].header = "from";
reply_to_map[0].fallback = NULL;
}
BR,
Jani.
next prev parent reply other threads:[~2015-12-04 17:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 16:28 notmuch-reply doesn't use Reply-To Damien Cassou
2015-12-04 12:07 ` David Bremner
2015-12-04 12:14 ` David Bremner
2015-12-04 15:06 ` Tomi Ollila
2015-12-04 16:40 ` Damien Cassou
2015-12-04 17:14 ` David Bremner
2015-12-04 17:14 ` Jani Nikula [this message]
2015-12-29 21:54 ` Michal Sojka
2015-12-29 21:55 ` [PATCH] doc/reply: Clarify how reply-to header is handled Michal Sojka
2016-03-14 23:39 ` David Bremner
2016-03-23 10:35 ` notmuch-reply doesn't use Reply-To David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twnygmps.fsf@nikula.org \
--to=jani@nikula.org \
--cc=damien@cassou.me \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).