From: Jani Nikula <jani@nikula.org>
To: Tomi Ollila <tomi.ollila@iki.fi>,
Mark Walters <markwalters1009@gmail.com>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs: interesting-buffer bugfixes/updates
Date: Sun, 23 Oct 2016 21:53:37 +0300 [thread overview]
Message-ID: <87twc2ew26.fsf@nikula.org> (raw)
In-Reply-To: <m2pomso1uu.fsf@guru.guru-group.fi>
On Sat, 22 Oct 2016, Tomi Ollila <tomi.ollila@iki.fi> wrote:
> On Sat, Oct 22 2016, Mark Walters <markwalters1009@gmail.com> wrote:
>
>> The command notmuch-interesting-buffer has got out of date -- it
>> doesn't mention notmuch-tree, and it still refers to message-mode not
>> notmuch-message-mode. Update both of these.
>>
>> This fixes the bug that notmuch-cycle-notmuch-buffers does not include
>> notmuch-tree or notmuch-message-mode buffers in its cycling.
>
> Looks pretty obvious to me. +1
And works for me.
Thanks for fixing this.
BR,
Jani.
>
>>
>> ---
>>
>> Jani pointed notmuch-cycle-notmuch-buffers out to me on irc (I hadn't
>> known it existed). It seems like it could be very useful.
>>
>> However, it call notmuch-interesting-buffer which has not been updated
>> since 2011, so doesn't know about notmuch-tree or
>> notmuch-message-mode. notmuch-tree came into mainline in 2013, and we
>> switched to notmuch-message-mode (from message-mode) in August last
>> year, so both bugs have been present for quite some time.
>>
>> Best wishes
>>
>> Mark
>>
>>
>>
>>
>>
>>
>> emacs/notmuch.el | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
>> index bd08aa0..2fc72b7 100644
>> --- a/emacs/notmuch.el
>> +++ b/emacs/notmuch.el
>> @@ -1066,8 +1066,9 @@ current search results AND that are tagged with the given tag."
>> (with-current-buffer b
>> (memq major-mode '(notmuch-show-mode
>> notmuch-search-mode
>> + notmuch-tree-mode
>> notmuch-hello-mode
>> - message-mode))))
>> + notmuch-message-mode))))
>>
>> ;;;###autoload
>> (defun notmuch-cycle-notmuch-buffers ()
>> --
>> 2.1.4
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> https://notmuchmail.org/mailman/listinfo/notmuch
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2016-10-23 18:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 12:10 [PATCH] emacs: interesting-buffer bugfixes/updates Mark Walters
2016-10-22 15:11 ` Tomi Ollila
2016-10-23 18:53 ` Jani Nikula [this message]
2016-10-26 1:03 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87twc2ew26.fsf@nikula.org \
--to=jani@nikula.org \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).