From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 891BA6DE1F7F for ; Tue, 28 Feb 2017 17:49:47 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.005 X-Spam-Level: X-Spam-Status: No, score=-0.005 tagged_above=-999 required=5 tests=[AWL=0.006, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1e1kdgga_PNZ for ; Tue, 28 Feb 2017 17:49:46 -0800 (PST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id C5D476DE1F33 for ; Tue, 28 Feb 2017 17:49:46 -0800 (PST) Received: from remotemail by fethera.tethera.net with local (Exim 4.84_2) (envelope-from ) id 1citO7-00058w-3X for notmuch@notmuchmail.org; Tue, 28 Feb 2017 20:49:07 -0500 Received: (nullmailer pid 11982 invoked by uid 1000); Wed, 01 Mar 2017 01:49:44 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: Re: read after free in notmuch new In-Reply-To: <87bmty6vwu.fsf@tethera.net> References: <87efyu6zdg.fsf@tethera.net> <87bmty6vwu.fsf@tethera.net> Date: Tue, 28 Feb 2017 21:49:44 -0400 Message-ID: <87tw7dvk93.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 01:49:47 -0000 David Bremner writes: > David Bremner writes: > >> I haven't had a chance to really track this down, but it seems there is >> a memory error in notmuch new (or a maybe false positive from valgrind). >> >> Attached is the log from running "make memory-test OPTIONS=--medium" on >> current git master (0e037c34). >> >> It looks like we talloc the message_id string with the message object as >> parent, but it somehow outlives the message object. > > Sorry, that had a few commits beyond master. > > master (08343d3d) gives essentially the same log. > This should be fixed as of commit 4e649d000b9d3764aea98cb0e1120947d7f76f3d