From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id C06206DE0B00 for ; Sat, 21 Oct 2017 12:31:40 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.019 X-Spam-Level: X-Spam-Status: No, score=0.019 tagged_above=-999 required=5 tests=[AWL=0.039, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 20qhPYSOtgWZ for ; Sat, 21 Oct 2017 12:31:40 -0700 (PDT) Received: from mail-lf0-f49.google.com (mail-lf0-f49.google.com [209.85.215.49]) by arlo.cworth.org (Postfix) with ESMTPS id 727616DE0AF4 for ; Sat, 21 Oct 2017 12:31:39 -0700 (PDT) Received: by mail-lf0-f49.google.com with SMTP id a16so16272906lfk.0 for ; Sat, 21 Oct 2017 12:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nikula-org.20150623.gappssmtp.com; s=20150623; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=kC+nOiQ7zysW59IqnFuc+hkvLdVq9JUBCNGJIej6Ezo=; b=QD77loXOyZ1y3jtnvYFNw8ChF5SZxThN92rWRold6IgVspldqeQwBZA4f0AvZtaxyG pInIrIFd/r/jOetm1Ry+EwdH2/LrKU7uladBRTvCeSLM9k687AcRXIky/qEcipeZudwr KlSHhWBBTAl8GgMqb8A2XM53A+l8khWnU9hIFBQpotcaWCUUt/fLhNvECuP0BgUooo/y 1+yv7JDMDnUVkaelAwCWOHBuXzDNEK5L9V8+cdEYL2dSzCG4rslA1o3s9mX0rXnbYDO3 qGXxpxoyLjnP5LXuFnK3aqCq/Ag5z3kwFiZ8CoQkWk6/LSSoijbHI2okeMdWJJQ1a2J2 44Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=kC+nOiQ7zysW59IqnFuc+hkvLdVq9JUBCNGJIej6Ezo=; b=dmtD6QkIgkG04fC7zNUHw30BATOwvb2mifIRyieTgBCiy/PNTtsp+G4pPfRtQBQwa3 5w9ZjamT3q/5u0sohiEemd4/zURdB4dlKvKgjWcn3P/OIc5zjy9vFnRtBlGJTk5npBKQ 3Nj3ggSmHgTQ0Y2pMf5Thz/b8ab6vjMgMG73yWkP0/HGigm59uIdU0H0PF1uqRQ3w2ea Dva6uNT1m7+Ir8BcI9cItPqopHCocGaVKY+4EHJI4HISSN0hR3s8Yf8YJYgpdhlac4Et mC1HhLbvi+Qcp37p7ORlwMZYbFVRmXER3dTTdMeZvsn4s3FSrWchBx8upZhLbHki50h3 pBMg== X-Gm-Message-State: AMCzsaULk8qHarx0DdWDoRXxc4OumPVH4+yl6x748D55PlDRbXhtng52 klN4uLb5SYF1wR0CGuUW5NZM/w== X-Google-Smtp-Source: ABhQp+Q3mhokOoiioZpsL1XDXfJpqgaq2aUjBBsKZWEFv8jkUScrAWG2K/VdggS74K1gXodCCI0+bQ== X-Received: by 10.25.37.201 with SMTP id l192mr2926368lfl.35.1508614297708; Sat, 21 Oct 2017 12:31:37 -0700 (PDT) Received: from localhost (mobile-access-5d6a0c-19.dhcp.inet.fi. [93.106.12.19]) by smtp.gmail.com with ESMTPSA id f14sm317659lfg.53.2017.10.21.12.31.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 21 Oct 2017 12:31:37 -0700 (PDT) From: Jani Nikula To: David Bremner , notmuch@notmuchmail.org Subject: Re: [PATCH] test: remove --root option and fix TMP_DIRECTORY cleanup In-Reply-To: <87mv4k8ry7.fsf@tethera.net> References: <878tg59qmw.fsf@tethera.net> <20171021115802.31197-1-jani@nikula.org> <87mv4k8ry7.fsf@tethera.net> Date: Sat, 21 Oct 2017 22:31:35 +0300 Message-ID: <87tvyswb54.fsf@nikula.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Oct 2017 19:31:40 -0000 On Sat, 21 Oct 2017, David Bremner wrote: > Jani Nikula writes: > >> The primary motivation here is to fix TMP_DIRECTORY cleanup prior to >> running each test when the current working directory is not the test >> subdirectory. Tests with failures would leave their TMP_DIRECTORY >> directory behind for debugging, and repeated out-of-tree test runs >> would have old temp directories. (This lead to e.g. T310-emacs.sh >> hanging because emacs would prompt for overwriting files.) >> >> We remove the likely anyway defunct --root test option while at it, >> just to be on the safe side when doing 'rm -rf' on the TMP_DIRECTORY. > > This seems to fix the problem I reported, however applying > > id:cd03efa9c93ee54f7e7f7e166079062984ddd658.1506370901.git.jani@nikula.org > > on top breaks > > ./devel/check-out-of-tree-build.sh test > > I get lots of errors along the lines of > > Error opening database at > /tmp/tmp.GD3HPpejbL/test/tmp.T350-crypto/mail/.notmuch: No such > file or directory > > So this patch seems to unbreak in-tree builds (and out of tree builds > where we copy the whole test hierarchy), and is probably worth applying > as is, but I wanted to give you a chance to respond before I proceed. So these two should be applied first, in either order: id:20171021192141.6666-1-jani@nikula.org id:20171021115802.31197-1-jani@nikula.org And then this should work on top: id:cd03efa9c93ee54f7e7f7e166079062984ddd658.1506370901.git.jani@nikula.org BR, Jani.