From: Floris Bruynooghe <flub@devork.be>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
Ruben Pollan <meskio@sindominio.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] python: add bindings for notmuch_message_get_propert(y/ies)
Date: Wed, 29 Nov 2017 22:40:15 +0100 [thread overview]
Message-ID: <87tvxcepc0.fsf@devork.be> (raw)
In-Reply-To: <87k1y97sor.fsf@fifthhorseman.net>
Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:
> On Tue 2017-11-28 23:46:11 +0100, Ruben Pollan wrote:
>> Message.get_property (prop) returns a string with the value of the property and
>> Message.get_properties (prop, exact=False) returns a list [(key, value)]
>
> This looks like a sensible approach to me. I'd be curious to hear what
> others think of this.
>
> In considering the API design space here, it occurs to me that it might
> be more pythonic for get_properties to return a dict like:
I would probably model properties as a dictionary in notdb, making this
a collections.abc.MutableMapping implementation with a .get_all(prop)
method inspired from the stdlib email.message package. This kind of
also implies making properties access a property rather then a method
call:
msg.properties['prop'] = 'foo'
msg.properties['prop'] = 'bar'
msg.properties['prop'] == 'foo' # pot luck
msg.properties.get_all('prop') == {'foo', 'bar'} # properties are unsorted are they?
This also has the binary question problem, is this returned as bytes or
as str? Current Python bindings seem to go for .decode('utf-8',
errors='ignore') afaik which is somewhat lossy.
Cheers,
Floris
next prev parent reply other threads:[~2017-11-29 21:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 22:29 [PATCH] python: add bindings for notmuch_message_get_property Ruben Pollan
2017-11-15 22:48 ` meskio
2017-11-17 9:03 ` Daniel Kahn Gillmor
2017-11-28 22:46 ` [PATCH] python: add bindings for notmuch_message_get_propert(y/ies) Ruben Pollan
2017-11-28 22:51 ` meskio
2017-11-29 1:57 ` Daniel Kahn Gillmor
2017-11-29 8:02 ` meskio
2017-11-29 8:03 ` Ruben Pollan
2017-12-23 15:59 ` David Bremner
2018-04-27 19:12 ` meskio
2018-04-27 19:15 ` Ruben Pollan
2018-05-01 13:06 ` David Bremner
2018-05-01 15:24 ` meskio
2018-05-01 15:28 ` Ruben Pollan
2018-05-02 0:08 ` David Bremner
2018-05-02 17:00 ` meskio
2018-05-02 17:01 ` Ruben Pollan
2018-05-02 23:50 ` David Bremner
2017-11-29 21:40 ` Floris Bruynooghe [this message]
2017-11-30 13:44 ` David Bremner
2017-11-30 14:19 ` Daniel Kahn Gillmor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvxcepc0.fsf@devork.be \
--to=flub@devork.be \
--cc=dkg@fifthhorseman.net \
--cc=meskio@sindominio.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).