From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Tomi Ollila <tomi.ollila@iki.fi>,
David Bremner <david@tethera.net>, "Rollins\,
Jameson" <jrollins@caltech.edu>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: parallelize test suite
Date: Mon, 06 May 2019 17:39:24 -0400 [thread overview]
Message-ID: <87tve7l0tv.fsf@fifthhorseman.net> (raw)
In-Reply-To: <m2v9yo4zse.fsf@guru.guru-group.fi>
[-- Attachment #1: Type: text/plain, Size: 975 bytes --]
On Sun 2019-05-05 19:44:01 +0300, Tomi Ollila wrote:
>> I actually think that CI and autobuilders *should* exercise the parallel
>> tests, as annoying as that might be initially, because it seems likely
>> to catch any other potential entanglements.
>
> ... after it has been proven a bit more to work...
i tend to think the other way around -- the way to prove it is to push
it into the CI pipelines on the development branch, rather than trying
to prove it on individual developer systems.
> One thing more, the "perverse" pre-caching done in add_email_corpus
> can be retained -- just do that step *before* going to parallelism...
You could do that, but i'm not sure how much you'd gain from it -- its
current implementation is all mixed up with the parallelized tests,
anyway. If you wanted to propose a concrete re-optimization like this,
i'd be happy to review it, test it and report back on the speedup
gained.
thanks for thinking this through, Tomi!
--dkg
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]
next prev parent reply other threads:[~2019-05-06 21:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 20:57 parallelize test suite Rollins, Jameson
2019-05-04 20:57 ` [PATCH 1/3] tests: remove some redundant pre-cleanup of the corpus MAIL_DIR Rollins, Jameson
2019-05-04 20:57 ` [PATCH 2/3] tests: remove entangling corpus index optimization Rollins, Jameson
2019-05-04 20:57 ` [PATCH 3/3] tests: run all tests in parallel, if available Rollins, Jameson
2019-05-06 4:44 ` [PATCH] tests: environment variable to specify that tests should be serialized Rollins, Jameson
2019-05-06 10:32 ` [PATCH] test: add configurable port to smtp-dummy David Bremner
2019-05-06 19:39 ` Tomi Ollila
2019-05-06 20:55 ` Daniel Kahn Gillmor
2019-05-07 10:20 ` [PATCH] test: let the OS choose a port for smtp-dummy David Bremner
2019-05-07 12:38 ` Daniel Kahn Gillmor
2019-05-08 15:59 ` Tomi Ollila
2019-05-10 10:16 ` David Bremner
2019-05-06 19:15 ` [PATCH] tests: environment variable to specify that tests should be serialized Tomi Ollila
2019-05-06 20:58 ` Daniel Kahn Gillmor
2019-05-05 10:22 ` [PATCH 1/3] tests: remove some redundant pre-cleanup of the corpus MAIL_DIR Tomi Ollila
2019-05-04 21:33 ` parallelize test suite Rollins, Jameson
2019-05-04 21:39 ` Daniel Kahn Gillmor
2019-05-04 22:53 ` David Bremner
2019-05-05 15:22 ` Daniel Kahn Gillmor
2019-05-05 16:44 ` Tomi Ollila
2019-05-06 21:39 ` Daniel Kahn Gillmor [this message]
2019-05-07 10:26 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tve7l0tv.fsf@fifthhorseman.net \
--to=dkg@fifthhorseman.net \
--cc=david@tethera.net \
--cc=jrollins@caltech.edu \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).