From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id BCDA66DE0286 for ; Fri, 21 Feb 2020 09:13:28 -0800 (PST) Authentication-Results: arlo.cworth.org; dkim=pass (2048-bit key; secure) header.d=jb55.com header.i=@jb55.com header.b="Q6D+xP1K"; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.365 X-Spam-Level: X-Spam-Status: No, score=-0.365 tagged_above=-999 required=5 tests=[AWL=-0.165, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 76Uey7tlyRvo for ; Fri, 21 Feb 2020 09:13:28 -0800 (PST) X-Greylist: delayed 399 seconds by postgrey-1.36 at arlo; Fri, 21 Feb 2020 09:13:27 PST Received: from jb55.com (jb55.com [45.79.91.128]) by arlo.cworth.org (Postfix) with ESMTPS id EB94E6DE024E for ; Fri, 21 Feb 2020 09:13:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d= jb55.com; h=from:to:subject:date:message-id; s=default; bh=EMog55RmWzplPgsV2E/830UUme8eeiGG2NArWPRw7co=; b=Q6D+xP1KXjIF+f+y+clnuYpuK0lxXOrS24ho579RtQRZl56wsBDGjiX6KbfiDHgwdZGrJVm2zij3aQ9Y390C3zfzHO/HvByLiunu9Pl3/2hIK8bfOdNt5T5pMWdssvIlkAWFjmh1GsqiHFZWopgUZpehG0SZHjBKL8sj/7VLQv5Sy0pRhkSvNOIq9s7VXasv32Y3r4ejb/dA6j4GJrVjUXXDNZIDKiAPiOjTjj5+MdbCdivN0dBm1CmDb1KCCGU/t3zVauFPFz77aTT9WfFn0vso1SyCcsi3GLhhUpQnor2Ulzn4tO3ovh+JmDPCXAP7LyW+XrTVk6r8KJJxP8mILA== Received: from jb55.com (S010660e327dca171.vc.shawcable.net [24.84.152.187]) by jb55.com (OpenSMTPD) with ESMTPSA id ce84dda8 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO; Fri, 21 Feb 2020 17:06:47 +0000 (UTC) From: William Casarin To: Daniel Kahn Gillmor , notmuch@notmuchmail.org Subject: Re: [PATCH v3 0/7] Port notmuch-show's x/X bindings to notmuch-tree In-Reply-To: <878skx9h9v.fsf@fifthhorseman.net> References: <20191228150124.20630-1-jb55@jb55.com> <878skx9h9v.fsf@fifthhorseman.net> Date: Fri, 21 Feb 2020 09:06:46 -0800 Message-ID: <87tv3j7tuh.fsf@jb55.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Feb 2020 17:13:28 -0000 Daniel Kahn Gillmor writes: > On Sat 2019-12-28 10:01:17 -0500, William Casarin wrote: >> These patches bring notmuch-tree more in line with the user experience >> of notmuch-show by adding the x/X bindings. > > It looks like this series has been reviewed by dme, and is presumably > approved by him, with the exception of patch 3/7, which > id:m25zhyxasu.fsf@dme.org suggests some improvement on. > > William, would you be up for doing one last re-spin of this series to > address dme's comments? it'd be nice to land this series unless someone > raises objections. I was planning on it but it fell by the wayside. The only comment was just a naming thing, perhaps we can just pull this and rename it in a future patch? I could do a whole new series but I feel like that is overkill.