Re: [PATCH] emacs: Use `cl-lib' instead of deprecated `cl'

[David Bremner <david@tethera.net>]

William Casarin <jb55@jb55.com> writes:

> From: Jonas Bernoulli <jonas@bernoul.li>
>
> Starting with Emacs 27 the old `cl' implementation is finally
> considered obsolete.  Previously its use was strongly discouraged
> at run-time but one was still allowed to use it at compile-time.
>
> For the most part the transition is very simple and boils down to
> adding the "cl-" prefix to some symbols.  A few replacements do not
> follow that simple pattern; e.g. `first' is replaced with `car',
> even though the alias `cl-first' exists, because the latter is not
> idiomatic emacs-lisp.

I get 3 test failures

T310-emacs "Incremental parsing of search results"
           not sure what the error is here, it just reports nil
           
T450-emacs-show "Show handles subprocess errors"
      *ERROR*: Symbol’s function definition is void: second

T720-emacs-attachment-warnings: "  notmuch-test-attachment-warning part 1
      *ERROR*: Symbol’s function definition is void: loop

A quick git grep suggests there are still cl-isms in the test-harness.

d