unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] tests/ruby: Ensure that test works for out-of-tree builds
Date: Tue, 26 May 2020 13:07:36 -0400	[thread overview]
Message-ID: <87tv02hbfr.fsf@fifthhorseman.net> (raw)
In-Reply-To: <20200526170602.1008191-1-dkg@fifthhorseman.net>

On Tue 2020-05-26 13:06:02 -0400, Daniel Kahn Gillmor wrote:
> ---
>  test/test-lib.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/test-lib.sh b/test/test-lib.sh
> index 792b1cb9..78a90862 100644
> --- a/test/test-lib.sh
> +++ b/test/test-lib.sh
> @@ -1081,7 +1081,7 @@ test_python() {
>  }
>  
>  test_ruby() {
> -    MAIL_DIR=$MAIL_DIR $NOTMUCH_RUBY -I $NOTMUCH_SRCDIR/bindings/ruby> OUTPUT
> +    MAIL_DIR=$MAIL_DIR $NOTMUCH_RUBY -I "$NOTMUCH_BUILDDIR/bindings/ruby"> OUTPUT
>  }
>  
>  test_C () {

I should note that i'm not a ruby developer, but this seems to be the
correct patch to solve the problem, similar to what Floris proposed to
fix the python-cffi test suite.

    --dkg

  reply	other threads:[~2020-05-26 17:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-22  1:29 python-cffi and ruby test suites fail in out-of-tree builds Daniel Kahn Gillmor
2020-05-23 19:52 ` Floris Bruynooghe
2020-05-26 17:08   ` Daniel Kahn Gillmor
2020-05-30 15:48   ` David Bremner
2020-05-26 17:06 ` [PATCH] tests/ruby: Ensure that test works for " Daniel Kahn Gillmor
2020-05-26 17:07   ` Daniel Kahn Gillmor [this message]
2020-05-31 19:16   ` David Bremner
2021-12-23 12:57 ` python-cffi and ruby test suites fail in " David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87tv02hbfr.fsf@fifthhorseman.net \
    --to=dkg@fifthhorseman.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).