From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cNTvB25KFF88OgAA0tVLHw (envelope-from ) for ; Sun, 19 Jul 2020 13:28:14 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id WKC9A25KFF8GVwAA1q6Kng (envelope-from ) for ; Sun, 19 Jul 2020 13:28:14 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1C7B19403A5 for ; Sun, 19 Jul 2020 13:28:13 +0000 (UTC) Received: from [144.217.243.247] (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 550851FC6E; Sun, 19 Jul 2020 09:28:08 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 1F2371FA58 for ; Sun, 19 Jul 2020 09:28:06 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 02F0C609DB; Sun, 19 Jul 2020 09:28:05 -0400 (EDT) Received: (nullmailer pid 168823 invoked by uid 1000); Sun, 19 Jul 2020 13:28:04 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: Re: [PATCH 8/8] test: add known broken test for n_d_get_default_indexopts In-Reply-To: <20200719131857.158655-9-david@tethera.net> References: <20200719131857.158655-1-david@tethera.net> <20200719131857.158655-9-david@tethera.net> X-List-To: notmuch Date: Sun, 19 Jul 2020 10:28:04 -0300 Message-ID: <87tuy3my6z.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: FXCNJA55HZ4UFLKTIRBVD367OLTTEEUJ X-Message-ID-Hash: FXCNJA55HZ4UFLKTIRBVD367OLTTEEUJ X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Daniel Kahn Gillmor X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 0.53 X-TUID: yxpPcuDuMis5 David Bremner writes: > Xapian exceptions are swallowed and turned into default return value. There is not much guidance in the API docs, so I'm hoping Daniel can clarify what the desired behaviour is when a Xapian exception is detected in notmuch_database_get_config. The choice in many places in the API would be to return NULL. d