From: David Bremner <david@tethera.net>
To: ralph@ml.seichter.de, notmuch@notmuchmail.org
Cc: Ralph Seichter <github@seichter.de>
Subject: Re: [PATCH] Rename version to version.txt
Date: Fri, 30 Oct 2020 16:21:09 -0300 [thread overview]
Message-ID: <87tuubh656.fsf@tethera.net> (raw)
In-Reply-To: <20201028144435.14718-1-ralph@ml.seichter.de>
ralph@ml.seichter.de writes:
> From: Ralph Seichter <github@seichter.de>
>
> Building Notmuch on macOS is known to cause problems because the Notmuch
> distribution archive contains two files named "version". These names
> clash with the <version> keyword as defined in C++20. Therefore, the
> existing naming will likely become a problem on other platforms as well,
> once compilers adopt the new standard.
>
pushed to master with the hopefully inoffensive change of calling
<version> a header rather than a keyword.
I've also merged master to release to start thinking about a point
release. I'd like to add the other recently discussed fix for OpenBSD.
d
prev parent reply other threads:[~2020-10-30 19:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 8:11 Clashes between "version" files and C++ keyword Ralph Seichter
2020-10-28 13:52 ` Tomi Ollila
2020-10-28 14:44 ` [PATCH] Rename version to version.txt ralph
2020-10-30 19:21 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuubh656.fsf@tethera.net \
--to=david@tethera.net \
--cc=github@seichter.de \
--cc=notmuch@notmuchmail.org \
--cc=ralph@ml.seichter.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).