unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] perf-test/T00-new: fix backup creation.
@ 2021-05-08 13:57 David Bremner
  2021-05-19 11:57 ` David Bremner
  0 siblings, 1 reply; 2+ messages in thread
From: David Bremner @ 2021-05-08 13:57 UTC (permalink / raw)
  To: notmuch; +Cc: David Bremner

"xargs tar cf backup.tar < $manifest" recreates the tar file with each
"batch" execed by xargs. In general this results in only a fraction of
the desired files being backed up.
---

I'm not sure if this is worth including in the point release: both the
risk and the benefit are relatively low since breaking the performance suite
probably mainly annoys me.

 performance-test/T00-new.sh | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/performance-test/T00-new.sh b/performance-test/T00-new.sh
index 53de1c27..de260b2d 100755
--- a/performance-test/T00-new.sh
+++ b/performance-test/T00-new.sh
@@ -5,16 +5,16 @@ test_description='notmuch new'
 . $(dirname "$0")/perf-test-lib.sh || exit 1
 
 uncache_database
-
 time_start
 
+manifest=$(mktemp manifestXXXXXX)
+find mail -type f ! -path 'mail/.notmuch/*' | sed -n '1~4 p' > $manifest
+xargs tar uf backup.tar < $manifest
+
 for i in $(seq 2 6); do
     time_run "notmuch new #$i" 'notmuch new'
 done
 
-manifest=$(mktemp manifestXXXXXX)
-
-find mail -type f ! -path 'mail/.notmuch/*' | sed -n '1~4 p' > $manifest
 # arithmetic context is to eat extra whitespace on e.g. some BSDs
 count=$((`wc -l < $manifest`))
 
@@ -26,8 +26,6 @@ perl -nle 'rename "$_.renamed", $_' $manifest
 
 time_run "new ($count mv back)" 'notmuch new'
 
-xargs tar cf backup.tar < $manifest
-
 perl -nle 'unlink $_; unlink $_.copy' $manifest
 
 time_run "new ($count rm)" 'notmuch new'
-- 
2.30.2

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] perf-test/T00-new: fix backup creation.
  2021-05-08 13:57 [PATCH] perf-test/T00-new: fix backup creation David Bremner
@ 2021-05-19 11:57 ` David Bremner
  0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2021-05-19 11:57 UTC (permalink / raw)
  To: notmuch

David Bremner <david@tethera.net> writes:

> "xargs tar cf backup.tar < $manifest" recreates the tar file with each
> "batch" execed by xargs. In general this results in only a fraction of
> the desired files being backed up.
> ---
>
> I'm not sure if this is worth including in the point release: both the
> risk and the benefit are relatively low since breaking the performance suite
> probably mainly annoys me.

applied to release and master.

d

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-05-19 11:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-08 13:57 [PATCH] perf-test/T00-new: fix backup creation David Bremner
2021-05-19 11:57 ` David Bremner

unofficial mirror of notmuch@notmuchmail.org

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://yhetil.org/notmuch/0 notmuch/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 notmuch notmuch/ https://yhetil.org/notmuch \
		notmuch@notmuchmail.org
	public-inbox-index notmuch

Example config snippet for mirrors.
Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.mail.notmuch.general
	nntp://news.gmane.io/gmane.mail.notmuch.general


code repositories for project(s) associated with this inbox:

	notmuch.git.git (no URL configured)

AGPL code for this site: git clone http://ou63pmih66umazou.onion/public-inbox.git