From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id iBlSBxuG12CXmwAAgWs5BA (envelope-from ) for ; Sat, 26 Jun 2021 21:55:07 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id mFH/AhuG12CFMwAAB5/wlQ (envelope-from ) for ; Sat, 26 Jun 2021 19:55:07 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 74ABC11EB4 for ; Sat, 26 Jun 2021 21:55:02 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 19900290D9; Sat, 26 Jun 2021 15:54:59 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id B54BA290C4 for ; Sat, 26 Jun 2021 15:54:56 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 8FE545FD21; Sat, 26 Jun 2021 15:54:56 -0400 (EDT) Received: (nullmailer pid 278684 invoked by uid 1000); Sat, 26 Jun 2021 19:54:55 -0000 From: David Bremner To: Felipe Contreras Subject: Re: [PATCH 2/2] ruby: enable garbage collection using talloc In-Reply-To: References: <20210517193915.1220114-1-felipe.contreras@gmail.com> <20210517193915.1220114-3-felipe.contreras@gmail.com> <874ke5tehj.fsf@tethera.net> <871r98u6he.fsf@tethera.net> Date: Sat, 26 Jun 2021 16:54:55 -0300 Message-ID: <87tulkxuy8.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 4HKUKU3O4BFFGYZRLB4JGAAZUPHUUVL3 X-Message-ID-Hash: 4HKUKU3O4BFFGYZRLB4JGAAZUPHUUVL3 X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: "notmuch@notmuchmail.org" , Tomi Ollila X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1624737302; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=b7qVDSnpbxbqLVgxIDWQl2wNlNBpcjyobCPsxKX81kk=; b=i3y7E5+QYC1X2rFgGeX45+HuVgvQN5gZYYEbZRSX0z/Ggh9CgqbobtyNxX/pm6fMBA8bY7 0wF5Yi9mD96O3uzkRvNFS2lr8yGWhwSj9G1LnWOC2cVaWB5NjBsQ8L6lcYz/dx1pFDDEFA 8XE9oEu1TlJGhIx5bKHYihk0Z88/KuYdNdDqOZgK5nLNUBRnTdepjRxpBp0r+N9J/i9UTS k788Cabs3IHatKQziFU+iZmBxx3SESUQxb7XF5c13CVFWHVG76tUihdvyYiWkxSzxjjO7y HnKxSVW5ctBrISGwI5Dk+Dua5KpVUBGNkhF6hbu2FGMp2YE0ANGynqG3VrhkkA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1624737302; a=rsa-sha256; cv=none; b=q9kWIVEWl3KZtk/GUWGGlf8ZJLkmklCnRd/vo/vJisj7PPWT2uPdOg88Fk4Pm8tA0pn64B opb92sb6VSJr8PNo4HCpyvzHZU+lk/W645PnwqYU9K4JfbPc7hRZ3ds34XE5dcx0Nr9xWr GPIMKUrhPU/FGCBlNhItL1eWns3WHRJCu/9JzeihTmWcICgZ0QEiOIF0yYB/V63T4m/n5N FQH68eHW1yh5xttQbycUkTtV81+efI4T6tgz8Tg3anogpOtC/SxsJKbqKTtXYeM6YbyckX EAzgrzMkf18HLqM4WRBzRhq/DnrD4g2LwT15wlkTJCwZ+F2DbEGPsq+qd7vycA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.01 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 74ABC11EB4 X-Spam-Score: -2.01 X-Migadu-Scanner: scn0.migadu.com X-TUID: 6Zn5WzU5UXT4 Felipe Contreras writes: >> >> One issue to double check: in a few places we explicitely _don't_ use >> talloc. What happens when those objects are passed to talloc_steal? > > Seems like talloc aborts. Are there any of such objects? > At least anything where notmuch.h says "allocated by malloc and should be freed by the caller". - all of the error_message output parameters - notmuch_database_get_config output parameter 'value'