From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id wNPUCgQ/22HjAgAAgWs5BA (envelope-from ) for ; Sun, 09 Jan 2022 21:01:08 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id KByBAwQ/22EXHQAAG6o9tA (envelope-from ) for ; Sun, 09 Jan 2022 21:01:08 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D020033AD4 for ; Sun, 9 Jan 2022 21:01:07 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id A98895F6CE; Sun, 9 Jan 2022 20:01:03 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 9C1BD5F468 for ; Sun, 9 Jan 2022 20:01:00 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 238AB5FC42; Sun, 9 Jan 2022 15:01:00 -0500 (EST) Received: (nullmailer pid 3894774 invoked by uid 1000); Sun, 09 Jan 2022 20:00:59 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: Re: [PATCH v2] bindings/python-cffi: search for config by default In-Reply-To: <20220108212143.3417678-1-david@tethera.net> References: <87czl2awtg.fsf@powell.devork.be> <20220108212143.3417678-1-david@tethera.net> Date: Sun, 09 Jan 2022 16:00:59 -0400 Message-ID: <87tuecsmpw.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: C3BDZHHRWCOPMEWEIQQWG5WSADXXFBEF X-Message-ID-Hash: C3BDZHHRWCOPMEWEIQQWG5WSADXXFBEF X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1641758467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=QPVcZolnA8AaSy+tsE540/uIbNGi2E5YzBz3GXRd7Ic=; b=oOWjYnBi2s21bEnlvSylcre39B4D15diqfsub01GcoWcrdUDLdj7g9rhNitBCYDr0OVoXg 5fffyxCFL+wsUlcBd6hUm3P7AVb2G76ul9flwDgPqqQI/ZJFCs7gaC4dieeqpJSQKDWI1w NJQU8wFPqrdlrdvai55K1w2ymFWxSK8ud1S8isUKZbmkwMZtNZZxaLML+dOaU5uQBz9qkE v7U6Q1r8r5T4pbbyckv+1esbFfCdp5GEydExLZg6MWlF2BWmF5PEJ4aZguNYj13efdgjy6 5PNPIUoO6aXwwWJ98qg1IRsqmOA1PiOpJAuIo7UgSZK+rmMdgYkuAxn7aKhUVw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1641758467; a=rsa-sha256; cv=none; b=QX7uuFKKkrJDIO1gc3PmM0ko1CElVjlWZs/PQM81zQYXOO4KZCkZZNf9koCa/ryCKCv1eJ EFIaMoaGgKQayDJGKJu6Vaqw4wFZijN0vKaHPIkg4YXJ/dTHu5N0Xt3Ti7m4qjLPHKsLRC kxtrLvHCq83G3XFo1h/9rS2CFlvTUnMp5yHrbw9nXEJ6ZZHx5jSnBqVBZnMe8YjQHtRRHr E8T1o21Z0RAkCHajPofFxSa1R+plAi9H8AlvqgneC0DiGu6ZCGWzmR3ytSfysd+EFVY4Mz snqVBBRBE2lVUjThUhpm+9JCzMY4p/VQ9DzGP6TwoItZe1c8V2q3HMqmOzzHMw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.33 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: D020033AD4 X-Spam-Score: -2.33 X-Migadu-Scanner: scn1.migadu.com X-TUID: ZZg2ijdr5uib David Bremner writes: > The previous (pre-0.34.2) constructor searched for a config file but > only if the database path was not specified, and only to retrieve > database.path. Neither of the available options (CONFIG.SEARCH or > CONFIG.NONE) matches this semantics exactly, but CONFIG.SEARCH causes > less breakage for people who relied on the old behaviour to set their > database.path [1]. Since it also seems like the friendlier option in > the long run, this commit switches to CONFIG.SEARCH as default. applied the fixed version to master and release. For some reason I only tested the original version by running pytest, but the notmuch test suite actually sets up an environment where the code is run without a config file, and that failed in the initial version. d