From: David Bremner <david@tethera.net>
To: erik colson <eco@ecocode.net>, notmuch@notmuchmail.org
Subject: Re: sexp and strings
Date: Fri, 01 Jul 2022 08:41:03 -0300 [thread overview]
Message-ID: <87tu81f4c0.fsf@tethera.net> (raw)
In-Reply-To: <874k0oz9uq.fsf@tethera.net>
David Bremner <david@tethera.net> writes:
>
> Although you have one too many sets of (), there is still a bug here.
>
> $ notmuch config set squery.D '(macro (dossier) (tag (regex ,dossier))'
>
> also doesn't work. Apparently both for regex and wildcard expansion I
> did not do macro parameter expansion. In the regex case the regex
> matching for tags actually happens at query construction time, so that's
> why it ends up as an empty query (presumably none of your tags starts
> with ,dossier).
>
> Anyway, I think I know how to fix this, it will mean that in the corner
> case of a regex starting with a comma, we'll have to use (regex ",foo").
This bug should be fixed in master as of
6a9ae990990848ec99107f2e2e6b6ae12dcd33df
prev parent reply other threads:[~2022-07-01 11:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-12 23:11 sexp and strings erik colson
2022-06-13 9:12 ` Michael J Gruber
2022-06-13 9:31 ` erik colson
2022-06-13 10:11 ` Michael J Gruber
2022-06-13 15:10 ` erik colson
2022-06-13 18:39 ` David Bremner
2022-06-14 11:22 ` [PATCH 1/2] test/sexp: add known broken tests for macro param inside rx/wildcard David Bremner
2022-06-14 11:22 ` [PATCH 2/2] lib/sexp: add parameter expansion for regex and wildcard David Bremner
2022-07-01 11:41 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tu81f4c0.fsf@tethera.net \
--to=david@tethera.net \
--cc=eco@ecocode.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).