From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id CAfrD+PpEGf37AAAqHPOHw:P1 (envelope-from ) for ; Thu, 17 Oct 2024 10:41:39 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id CAfrD+PpEGf37AAAqHPOHw (envelope-from ) for ; Thu, 17 Oct 2024 12:41:39 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=pengjiz.com header.s=fm3 header.b="o+GpUF2/"; dkim=fail ("body hash did not verify") header.d=messagingengine.com header.s=fm2 header.b=dB5P5LcK; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1729161699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=58NteVAXiUg7fRuMmqgxkT9Ms0Ek2j2pFOB004FZsiw=; b=Q6RqB98jtsSwKx3hZC8F1HLEeI9HGRrqA6Qu0+V3ybV+BeJsd0fWISFQOU23mvYnNyUVPp rwO49rybGWl5/Jd7yB4ZPrjtb3GNCIzC/osd0cKroP8DVLyjfJ+Qbz4KCU6KNEJQkQaE0Y DIxIeulKsHtIrHpv7EQPlGkzEXa20Uq7HIbs3bAl9dYSD7Hf4qlIatzMiZcXJXVk6Ly5QN XPqBQ27k4v5VCpARt+2BVzqyM9NK3Bg8/gnvlF7KRtbKAGeVwzTpr7xXziVRBwUjVnkAvb 8TyR16zpUL+YdGcK4tSU7a4CqlvTUMlP6CDuoHzqT2gIykL7WMQuD8CXJHJAiw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=pengjiz.com header.s=fm3 header.b="o+GpUF2/"; dkim=fail ("body hash did not verify") header.d=messagingengine.com header.s=fm2 header.b=dB5P5LcK; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none ARC-Seal: i=1; s=key1; d=yhetil.org; t=1729161699; a=rsa-sha256; cv=none; b=lmnkTBHptgI8gUSomCF5Crjfv12zwD+j+ZfwmuTJtG4CAn/GSPB0CZ3DJ89blCfSGW0L6V fFlc107z2MZpYzWEyjdJ0Zi7bPh6pgeav8PnLTQl9hy/PQvTad9q6B2X51NENco5l3MOPZ k8Qp3rDyCqwLD/RYzVKM+HXfzS/qkvJv4s71IQ1puNV61oOsRz2oCcnzHCd7UKdxz7vEzC SMWjBvCCC9PTv+a8wXyYS892mIxBo4wfvp8dS4KGLTNCQ5kakOVZySZCxxZJopwa5QiIZh gwmfdXyg2mcDNoTE5HMue9XUtQL2QmX9z9pjwTDYMewB6EaYbGC+VRtPy9Pd5Q== Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 865197A336 for ; Thu, 17 Oct 2024 12:41:38 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 76B6B5F7B5; Thu, 17 Oct 2024 10:32:13 +0000 (UTC) Received: from fhigh-a3-smtp.messagingengine.com (fhigh-a3-smtp.messagingengine.com [103.168.172.154]) by mail.notmuchmail.org (Postfix) with ESMTPS id 0BCF25F6CD for ; Thu, 17 Oct 2024 10:32:11 +0000 (UTC) Received: from phl-compute-07.internal (phl-compute-07.phl.internal [10.202.2.47]) by mailfhigh.phl.internal (Postfix) with ESMTP id B27EC11400EC; Thu, 17 Oct 2024 06:32:09 -0400 (EDT) Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-07.internal (MEProxy); Thu, 17 Oct 2024 06:32:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pengjiz.com; h= cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1729161129; x=1729247529; bh=ApPcssFiUg 6ixwyG+OcE2QozTwcdlCQIIeN3IUGXMUU=; b=o+GpUF2/Ncn0fHKaTUIoS8flNP uLv9IrkUEp7o0M2R6A5cUZy2jFfl1aoTKMgrgEEBkrhUAfoI/lpvFYeVL5GmsEVZ mOVQkeCuC3kjWCq1wIXwBW47+xSRJ/WUithPnk7xMTox2qSprvIvJ9BiypGWKKvv ZrEC+2b9gXfQpyv72cxaWpjpyamqbN9p+UdG3p5v4dq0B2WM+5L8xdTS/IQOpuNN ZEFd5zq0OdNTY1PF44d/X5RHuBHKJHzzfQJ3ecSD5VwGy9eU/c39xlQjp/H46v3q uFhUsHPkxHSz7gSqpcnn46UqzXDvoK5viNqcv8q1XJPqbEURm6TWfQ4rxb4w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1729161129; x=1729247529; bh=ApPcssFiUg6ixwyG+OcE2QozTwcd lCQIIeN3IUGXMUU=; b=dB5P5LcKdRp7bgnBFaBENwjB+6Q1zMU284+aAYlEV2uZ NS/Yx4CbRurHQqw7APXdddsLAq1NY4UaozH9nXXS+h6Ic030MFjb2U5FAYPIaB3J xM/67B97loAa4SEYP0BkTUkYOjRrr66A/G+ZjIIln6eClZugshKhI2mIijMe654O M506SgOQJ3N4KsL/KKnEJSIqz5yL9mpxxAkGA654wPrSmuNu/WpjcOUqk1XbqxBC 0n4zz/GBYxfNkeGdQh9TLIT/HkYS3amc+tSIAzpKfLfzT3yKUFkhae/FVFHrjNGd 18C1hlX2b6Tmf7P2Cov3qjq+rPVr8Uwubcu7OagDwA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrvdehuddgvdelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhephffvufgjfhffkfggtgesthdtredttddttdenucfh rhhomheprfgvnhhgjhhiucgkhhgrnhhguceomhgvsehpvghnghhjihiirdgtohhmqeenuc ggtffrrghtthgvrhhnpeeivdekhfekieetfefgueevkeduteevveeggffhleekveehtdeg veeggfduhedvgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehmvgesphgvnhhgjhhiiidrtghomhdpnhgspghrtghpthhtohepvddpmhhouggv pehsmhhtphhouhhtpdhrtghpthhtohepkhhrihhssggrlhhinhhtohhnrgesghhmrghilh drtghomhdprhgtphhtthhopehnohhtmhhutghhsehnohhtmhhutghhmhgrihhlrdhorhhg X-ME-Proxy: Feedback-ID: i16614472:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 17 Oct 2024 06:32:08 -0400 (EDT) From: Pengji Zhang To: Kristoffer Balintona , notmuch@notmuchmail.org Subject: Re: Obey message-cite-reply-position from Emacs' message.el In-Reply-To: References: Date: Thu, 17 Oct 2024 18:31:41 +0800 Message-ID: <87ttdbrpf6.fsf@pengjiz.com> MIME-Version: 1.0 Message-ID-Hash: VJXJS3KLZPRSPE5MZUTBVL32OXZB767S X-Message-ID-Hash: VJXJS3KLZPRSPE5MZUTBVL32OXZB767S X-MailFrom: me@pengjiz.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 6.71 X-Spam-Score: 6.71 X-Migadu-Queue-Id: 865197A336 X-TUID: wPcraNLI3Htg Kristoffer Balintona writes: > Hello, Hello! > The current behavior of notmuch accords with the user values of below > and traditional but not above. > > The notmuch function responsible for the position of the signature > (or, rather, the position of the citations) is notmuch-mua-reply. I > have attached a patch that adds a brief snippet which obeys > message-cite-reply-position when its value is above. This indeed seems reasonable. Thank you! I am not a maintainer, but here are some comments of mine. > diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el > index bf62b656..1d1a1591 100644 > --- a/emacs/notmuch-mua.el > +++ b/emacs/notmuch-mua.el > @@ -295,6 +295,20 @@ Typically this is added to `notmuch-mua-send-hook'." > (when message-signature-insert-empty-line > (forward-line -1)) > (goto-char (point-max)))) > + ;; If `message-cite-reply-position' is `above', e.g., for Gmail-like > + ;; email replies, then before inserting the citation, put the point > + ;; after the signature and insert a newline for spacing. Also respects > + ;; if `message-cite-reply-position' is set via `message-cite-style'. > + (when (or (equal message-cite-reply-position 'above) Nit: I think it is slightly better to use 'eq' instead of 'equal' here. > + (and message-cite-style > + (eq (eval (cadr > + (assoc 'message-cite-reply-position Likewise, here we may use 'assq'. > + (if (symbolp message-cite-style) > + (eval message-cite-style) Here I think it is better to use 'symbol-value' instead of 'eval'. > + message-cite-style)))) > + 'above))) > + (goto-char (point-max)) > + (insert "\n")) > (let ((from (plist-get original-headers :From)) > (date (plist-get original-headers :Date)) > (start (point))) Regards, Pengji