unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Damien Cassou <damien@cassou.me>
To: Pengji Zhang <me@pengjiz.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] emacs/show: Only recenter interactively
Date: Tue, 17 Dec 2024 20:32:11 +0100	[thread overview]
Message-ID: <87ttb2nm10.fsf@cassou.me> (raw)
In-Reply-To: <87ikria5ze.fsf@pengjiz.com>

Pengji Zhang <me@pengjiz.com> writes:
> Besides, do you have other use cases for calling those commands
> non-interactively? If not, IMO this time it might be better to only
> change 'notmuch-show-previous-message' (or
> 'notmuch-show-imenu-prev-index-position-function'), so to fix the issue
> you had with 'which-function-mode'. After a closer look, I have an
> impression that those commands are meant to be interactive only.

This is a brilliant idea. I submitted a new patch:
https://nmbug.notmuchmail.org/nmweb/show/20241217192919.889035-1-damien%40cassou.me


-- 
Damien Cassou

"Success is the ability to go from one failure to another without
losing enthusiasm." --Winston Churchill

      reply	other threads:[~2024-12-17 19:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-23 15:16 [PATCH] emacs/show: Only recenter interactively Damien Cassou
2024-12-15  8:12 ` Damien Cassou
2024-12-15  9:33 ` Pengji Zhang
2024-12-15 12:47   ` Damien Cassou
2024-12-17 11:44     ` Pengji Zhang
2024-12-17 19:32       ` Damien Cassou [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ttb2nm10.fsf@cassou.me \
    --to=damien@cassou.me \
    --cc=me@pengjiz.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).