From: Carl Worth <cworth@cworth.org>
To: racin@free.fr, Sebastian Spaeth <Sebastian@SSpaeth.de>
Cc: notmuch <notmuch@notmuchmail.org>
Subject: Re: [PATCH] add notmuch-show-delete keybinding 'd'
Date: Wed, 24 Feb 2010 10:53:50 -0800 [thread overview]
Message-ID: <87sk8qwjlt.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <1161359196.2247691263984967906.JavaMail.root@zimbra1-e1.priv.proxad.net>
[-- Attachment #1: Type: text/plain, Size: 857 bytes --]
On Wed, 20 Jan 2010 11:56:07 +0100 (CET), racin@free.fr wrote:
> I posted a similar patch a while ago, that also did not show deleted
> messages by default. Don't know if Carl wants to integrate this though
OK. When two people are independently contributing similar
functionality, it's more than clear that I'm far too behind on patch
review.
Matthieu, I've just posted my review of your original patch. I think I
like the name "deleted" for the tag rather than "delete", (it's
consistent with "unread" at least that way). And I like the support for
excluding deleted results in that patch as well.
But this patch does have two good ideas not in the other patch, (both of
which I mentioned in the review):
1. It adds a keybinding to the notmuch-show mode
2. It removes the "inbox" and "unread" tags while adding the tag to
indicate deletion.
-Carl
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2010-02-24 18:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 10:32 [PATCH] add notmuch-show-delete keybinding 'd' Sebastian Spaeth
2010-01-20 10:56 ` racin
2010-02-24 18:53 ` Carl Worth [this message]
2010-02-24 19:01 ` Jameson Rollins
2010-02-24 19:28 ` Carl Worth
2010-02-24 19:46 ` Jameson Rollins
2010-02-25 10:53 ` Sebastian Spaeth
2010-02-25 14:21 ` James Vasile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sk8qwjlt.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=Sebastian@SSpaeth.de \
--cc=notmuch@notmuchmail.org \
--cc=racin@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).