From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 24DA240DBD2 for ; Thu, 11 Nov 2010 07:57:53 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.9 X-Spam-Level: X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5 tests=[BAYES_00=-1.9] autolearn=unavailable Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EDrde+fVQX3w for ; Thu, 11 Nov 2010 07:57:40 -0800 (PST) Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) by olra.theworths.org (Postfix) with ESMTP id 451DD40DBFB for ; Thu, 11 Nov 2010 07:57:40 -0800 (PST) Received: from localhost (unknown [192.168.200.4]) by max.feld.cvut.cz (Postfix) with ESMTP id 94F7B19F334C; Thu, 11 Nov 2010 16:57:39 +0100 (CET) X-Virus-Scanned: IMAP AMAVIS Received: from max.feld.cvut.cz ([192.168.200.1]) by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new, port 10044) with ESMTP id g+qALDpSh9zb; Thu, 11 Nov 2010 16:57:38 +0100 (CET) Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) by max.feld.cvut.cz (Postfix) with ESMTP id 15BD319F3340; Thu, 11 Nov 2010 16:57:38 +0100 (CET) Received: from steelpick.2x.cz (note-sojka.felk.cvut.cz [147.32.86.30]) (Authenticated sender: sojkam1) by imap.feld.cvut.cz (Postfix) with ESMTPSA id 14CD1FA004; Thu, 11 Nov 2010 16:57:38 +0100 (CET) Received: from wsh by steelpick.2x.cz with local (Exim 4.72) (envelope-from ) id 1PGZWr-0001Cw-SE; Thu, 11 Nov 2010 16:57:37 +0100 From: Michal Sojka To: Carl Worth , notmuch@notmuchmail.org Subject: Re: [PATCH] test: Better handling of stdout and stderr In-Reply-To: <8739r8bt9u.fsf@yoom.home.cworth.org> References: <1289346035-24904-1-git-send-email-sojkam1@fel.cvut.cz> <87k4kkq3r2.fsf@yoom.home.cworth.org> <8739r8bt9u.fsf@yoom.home.cworth.org> User-Agent: Notmuch/0.4-30-ga01dbf0 (http://notmuchmail.org) Emacs/23.2.1 (x86_64-pc-linux-gnu) Date: Thu, 11 Nov 2010 16:57:37 +0100 Message-ID: <87sjz7hmz2.fsf@steelpick.2x.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Nov 2010 15:57:53 -0000 On Thu, 11 Nov 2010, Carl Worth wrote: > On Wed, 10 Nov 2010 13:15:45 -0800, Carl Worth wrote: > > Meanwhile, I've just now pushed out my little test-lib.sh change, so you > > can update the patch for that as well. > > Oh, and one other thing I forgot to mention about the patch. It > currently talks about things along the lines of "git-style tests" and > "cworth-style tests". > > You and I might understand perfectly well what that means now, but we > need the test suite to be independently comprehensible. (I'd like to be > able to understand it myself when I look at it again in the future, > having forgotten the current history.) > > So if you could describe these instead as something like "tests using > test_expect_success" vs. "tests using > test_begin_subtest/test_expect_equal" or something like that, that would > be great. I'll look at this tomorrow. -Michal