From: Carl Worth <cworth@cworth.org>
To: Mark Anderson <MarkR.Anderson@amd.com>,
Austin Clements <amdragon@mit.edu>,
Mark Anderson <ma.skies@gmail.com>
Cc: "notmuch@notmuchmail.org" <notmuch@notmuchmail.org>
Subject: Re: [PATCH] test:Improve test behaviors when --root is used
Date: Tue, 28 Jun 2011 13:28:10 -0700 [thread overview]
Message-ID: <87sjqt8zvp.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <3wd39iuubbs.fsf@testarossa.amd.com>
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
On Mon, 27 Jun 2011 17:03:03 -0600, Mark Anderson <MarkR.Anderson@amd.com> wrote:
> On Mon, 27 Jun 2011 15:50:47 -0500, Austin Clements <amdragon@mit.edu> wrote:
> > This looks great (modulo one bug, below). I've wanted to run the
> > tests on tmpfs before, but was too lazy to actually fix the tests.
Yes, it does look great. Thanks for the patch, Mark!
Did you miss Austin's note about a possible bug? (You quoted it but
didn't reply). See below:
> > > run_test(){
> > > - result=$(LD_LIBRARY_PATH=../../lib ./symbol-test 2>&1)
> > > + result=$(LD_LIBRARY_PATH=$TEST_DIRECTORY/../../lib ./symbol-test 2>&1)
> >
> > Did you mean $TEST_DIRECTORY/../lib?
If you could follow up with an updated patch, (or an argument that the
original patch is correct), that would be great.
-Carl
--
carl.d.worth@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2011-06-28 20:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-27 16:09 [PATCH] test:Improve test behaviors when --root is used Mark Anderson
2011-06-27 20:50 ` Austin Clements
2011-06-27 23:03 ` Mark Anderson
2011-06-28 20:28 ` Carl Worth [this message]
2011-06-28 21:25 ` [PATCH v2] " Mark Anderson
2011-06-28 22:11 ` [PATCH v3] " Mark Anderson
2011-06-28 23:03 ` Carl Worth
2011-06-29 20:20 ` Pieter Praet
2011-06-29 20:23 ` [PATCH] test: revert non-intentional changes introduced in eb4cf465 Pieter Praet
2011-06-29 21:23 ` Carl Worth
2011-06-28 6:36 ` [PATCH] test:Improve test behaviors when --root is used Pieter Praet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjqt8zvp.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=MarkR.Anderson@amd.com \
--cc=amdragon@mit.edu \
--cc=ma.skies@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).