From: Pieter Praet <pieter@praet.org>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
Daniel Schoepe <daniel.schoepe@googlemail.com>,
notmuch@notmuchmail.org
Subject: Re: [PATCH v2] emacs: Turn id:"<message-id>" elements into buttons for notmuch searches
Date: Thu, 07 Jul 2011 10:07:00 +0200 [thread overview]
Message-ID: <87sjqifra3.fsf@praet.org> (raw)
In-Reply-To: <87r5624l3g.fsf@gmail.com>
On Thu, 07 Jul 2011 11:16:03 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Hi Daniel.
>
> On Wed, 6 Jul 2011 16:18:01 +0200, Daniel Schoepe <daniel.schoepe@googlemail.com> wrote:
> > This fixes the minor annoyance that message ids were parsed as mail
> > addresses by goto-address-mode in notmuch-show buffers.
>
> I did not try it yet but it looks like a nice feature. Though I have
> some questions on the code below.
>
> > ---
> > emacs/notmuch-show.el | 24 +++++++++++++++++++++---
> > 1 files changed, 21 insertions(+), 3 deletions(-)
> >
> > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> > index f96743b..f924d17 100644
> > --- a/emacs/notmuch-show.el
> > +++ b/emacs/notmuch-show.el
> > @@ -27,6 +27,7 @@
> > (require 'mm-decode)
> > (require 'mailcap)
> > (require 'icalendar)
> > +(require 'goto-addr)
> >
> > (require 'notmuch-lib)
> > (require 'notmuch-query)
> > @@ -778,6 +779,24 @@ current buffer, if possible."
> > (defvar notmuch-show-parent-buffer nil)
> > (make-variable-buffer-local 'notmuch-show-parent-buffer)
> >
> > +(defun notmuch-show-buttonise-links (start end)
> > + "Buttonise URLs and mail addresses between START and END.
> > +
> > +This also turns id:\"<message id>\"-parts into buttons for
> > +a corresponding notmuch search."
> > + (goto-address-fontify-region start end)
> > + (save-excursion
> > + (goto-char start)
> > + (while (re-search-forward "id:\"[^ ]+\"" end t)
> > + ;; remove the overlay created by goto-address-mode
> > + (remove-overlays (match-beginning 0) (match-end 0) 'goto-address t)
>
> Why do we need to remove `goto-address-mode' overlays if it is not
> enabled ((goto-address-mode t) is below is removed)?
Because those overlays got added by `goto-address-fontify-region'.
In fact, all `goto-address-mode' does, essentially, is call
(jit-lock-register #'goto-address-fontify-region)
> > + (make-text-button (match-beginning 0) (match-end 0)
> > + 'action `(lambda (arg)
> > + (notmuch-search ,(match-string-no-properties 0)))
> > + 'follow-link t
> > + 'help-echo "Mouse-1, RET: search for this message"
> > + 'face goto-address-mail-face))))
> > +
> > ;;;###autoload
> > (defun notmuch-show (thread-id &optional parent-buffer query-context buffer-name crypto-switch)
> > "Run \"notmuch show\" with the given thread ID and display results.
> > @@ -822,9 +841,8 @@ function is used. "
> > (notmuch-show-insert-forest
> > (notmuch-query-get-threads basic-args))))
> >
> > - ;; Enable buttonisation of URLs and email addresses in the
> > - ;; buffer.
> > - (goto-address-mode t)
>
> `goto-address-mode' creates buttons not only for email addresses but
> also for URLs. Do we loose it now?
Nope, everything remains functional.
> Regards,
> Dmitry
>
> > + (jit-lock-register #'notmuch-show-buttonise-links)
> > +
> > ;; Act on visual lines rather than logical lines.
> > (visual-line-mode t)
> >
> > --
> > 1.7.5.4
> >
> > _______________________________________________
> > notmuch mailing list
> > notmuch@notmuchmail.org
> > http://notmuchmail.org/mailman/listinfo/notmuch
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
Peace
--
Pieter
next prev parent reply other threads:[~2011-07-07 8:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-05 20:12 [PATCH] emacs: Turn id:"<message-id>" elements into buttons for notmuch searches Daniel Schoepe
2011-07-06 14:18 ` [PATCH v2] emacs: Turn id:"<message-id>" elements into buttons for Daniel Schoepe
2011-07-06 14:18 ` [PATCH v2] emacs: Turn id:"<message-id>" elements into buttons for notmuch searches Daniel Schoepe
2011-07-07 7:04 ` Pieter Praet
2011-07-07 7:16 ` Dmitry Kurochkin
2011-07-07 8:07 ` Pieter Praet [this message]
2011-07-07 8:15 ` Daniel Schoepe
2011-07-07 8:22 ` Dmitry Kurochkin
2011-10-11 14:27 ` Daniel Schoepe
2011-10-17 9:16 ` Thomas Schwinge
2011-10-17 12:13 ` Daniel Schoepe
2011-10-17 13:11 ` Thomas Schwinge
2011-10-17 13:43 ` Daniel Schoepe
2011-10-28 14:48 ` [PATCH v3] emacs: Turn id:"<message-id>" elements into buttons for Daniel Schoepe
2011-10-28 14:48 ` [PATCH v3] emacs: Turn id:"<message-id>" elements into buttons for notmuch searches Daniel Schoepe
2011-10-28 17:21 ` [PATCH v3] emacs: Turn id:"<message-id>" elements into buttons for David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjqifra3.fsf@praet.org \
--to=pieter@praet.org \
--cc=daniel.schoepe@googlemail.com \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).