From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 4A2AE429E25 for ; Sat, 19 Nov 2011 04:59:36 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id AFgZBbaGFVEa for ; Sat, 19 Nov 2011 04:59:35 -0800 (PST) Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id B53F8431FD0 for ; Sat, 19 Nov 2011 04:59:35 -0800 (PST) Received: from zancas.localnet (fctnnbsc36w-156034074106.pppoe-dynamic.High-Speed.nb.bellaliant.net [156.34.74.106]) (authenticated bits=0) by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id pAJCxUTA008951 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO); Sat, 19 Nov 2011 08:59:31 -0400 Received: from bremner by zancas.localnet with local (Exim 4.77) (envelope-from ) id 1RRkW1-0005VA-Vn; Sat, 19 Nov 2011 08:59:29 -0400 From: David Bremner To: Dmitry Kurochkin , notmuch@notmuchmail.org Subject: Re: [PATCH v2] Output unmodified Content-Type header value for JSON format. In-Reply-To: <1321676321-27745-1-git-send-email-dmitry.kurochkin@gmail.com> References: <1321659905-24367-1-git-send-email-dmitry.kurochkin@gmail.com> <1321676321-27745-1-git-send-email-dmitry.kurochkin@gmail.com> User-Agent: Notmuch/0.10~rc2 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sat, 19 Nov 2011 08:59:29 -0400 Message-ID: <87sjlktgi6.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Nov 2011 12:59:36 -0000 On Sat, 19 Nov 2011 08:18:41 +0400, Dmitry Kurochkin wrote: > Before the change, notmuch used g_mime_content_type_to_string(3) > function to output Content-Type header value. Turns out it outputs > only "type/subtype" part and ignores all parameters. Also, if there > is no Content-Type header, default "text/plain" value is used. Hi Dmitry; I haven't analyzed the substance of your patch yet, but I did have a couple thoughts while reading your mail. - It seems that every time we change the json format, we have a round of suffering because people are unable to detect a mismatch between their emacs code and the cli. Not that this is your problem necessarily, but it would be nice if someone (TM), would come up with some version info for the json output, and a patch to check it on the emacs side. - The previous point is a bit of a counterargument to this, but in general, I think I prefer patches that modify the core seperate from those that do emacs (or python, or ...) stuff. - I understand you want to make your patches reviewable without applying by including lots of context, but at a certain point it has actually the opposite effect for me. I just don't read 900+ line emails ;). Of course, I can still apply the patch and look at it, so it's really up to you. d