From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 425F2429E5F for ; Tue, 17 Jan 2012 11:36:13 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 1.7 X-Spam-Level: * X-Spam-Status: No, score=1.7 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, FREEMAIL_REPLY=2.499, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kGWomz0uDeXJ for ; Tue, 17 Jan 2012 11:36:12 -0800 (PST) Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 7C222429E3B for ; Tue, 17 Jan 2012 11:36:12 -0800 (PST) Received: by bkty12 with SMTP id y12so895924bkt.26 for ; Tue, 17 Jan 2012 11:36:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=CSY35tTzg15ZpF/c4sMsupem+b2WV7x8zHN+iwv5PV8=; b=dsHajYE0ZCc460pg3EEPksQS1Je/GYlF+j33GqL8hoBgbmfNF2e2rE/joBGbtftTGA CJKZm1jY//JVAqIiZchkTxxX/D8ApZ+N5LawR6ZCiq9wVeHQABfBZli26YaOZAxusmnr ZUMM7wQXej7SXE7mpfKzNzAG73MYpYeJSXJuA= Received: by 10.204.141.2 with SMTP id k2mr7431255bku.78.1326828971279; Tue, 17 Jan 2012 11:36:11 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id ig13sm17069333bkc.9.2012.01.17.11.36.09 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 17 Jan 2012 11:36:09 -0800 (PST) From: Dmitry Kurochkin To: Jani Nikula , David Edmondson , notmuch@notmuchmail.org Subject: Re: [PATCH 1/4] emacs: unify search mechanisms In-Reply-To: <87boq3dein.fsf@nikula.org> References: <1324786495-14221-1-git-send-email-dmitry.kurochkin@gmail.com> <87ehuzvpul.fsf@gmail.com> <87boq3dein.fsf@nikula.org> User-Agent: Notmuch/0.11+73~g8a5402e (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Tue, 17 Jan 2012 23:35:14 +0400 Message-ID: <87sjjew2a5.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2012 19:36:13 -0000 Hello. On Mon, 16 Jan 2012 12:21:20 +0000, Jani Nikula wrote: > On Mon, 16 Jan 2012 15:39:14 +0400, Dmitry Kurochkin wrote: > > On Mon, 16 Jan 2012 11:35:37 +0000, David Edmondson wrote: > > > On Sun, 25 Dec 2011 08:14:52 +0400, Dmitry Kurochkin wrote: > > > > Before the change, there were two ways to do search in Emacs UI: > > > > search widget in notmuch-hello buffer and `notmuch-search' > > > > function bound to "s". Internally, notmuch-hello search widget > > > > uses `notmuch-search' function. But it uses widget field input > > > > instead of minibuffer. Such duplication is a major issue for > > > > notmuch-hello usability: search interface is inconsistent and > > > > lacks features that are available in minibuffer (e.g. history and > > > > auto completion). Some of these features may be relatively easy > > > > to implement for notmuch-hello search, others would be much more > > > > tricky. So to avoid duplication, make UI more consistent, bring > > > > notmuch-hello search to feature parity with the minibuffer > > > > search, the patch replaces notmuch-hello search widget and with a > > > > button that works the same way as "s" key binding. > > > > > > Dmitry, if Daniel re-submits his patches to allow the construction of > > > `notmuch-hello' buffers to be configured, it seems that this patchset > > > would become unnecessary. Is that correct? > > > > Right. We will just need to fix the 's' key binding. Looking forward > > for that. > > Isn't (something like) this still needed to merge the search histories: > > id:"1324698436-8532-1-git-send-email-dmitry.kurochkin@gmail.com" > I have sent a new patch series implementing the changes [1]. Regards, Dmitry [1] id:1326828850-8519-1-git-send-email-dmitry.kurochkin@gmail.com > > Jani.