From: Sebastien Binet <seb.binet@gmail.com>>
To: Justus Winter <4winter@informatik.uni-hamburg.de>,
David Bremner <david@tethera.net>
Cc: , notmuch mailing list <notmuch@notmuchmail.org>
Subject: Re: [PATCH] go: Update to the current notmuch_database_find_message API
Date: Mon, 30 Apr 2012 22:14:37 +0200 [thread overview]
Message-ID: <87sjfldljm.fsf@cern.ch> (raw)
In-Reply-To: <20120430195420.2528.48612@thinkbox.jade-hamburg.de>
[-- Attachment #1: Type: text/plain, Size: 1886 bytes --]
Justus,
Justus Winter <4winter@informatik.uni-hamburg.de> writes:
> Quoting David Bremner (2012-04-30 13:53:47)
>> Austin Clements <amdragon@MIT.EDU> writes:
>>
>> > The signature of notmuch_database_find_message was changed in 02a30767
>> > to report errors and the Go bindings were never updated. This brings
>> > the Go bindings in sync with that change and at least makes them
>> > compile with Go r60.3, the last release before Go 1.
>>
>> I don't have any easy way to test this, since the current versions in
>> Debian are all based on Go 1. On the other hand I guess it doesn't make
>> things worse. Anybody have any objections to this patch?
>
> lgtm.
>
>> In the long run we have to decide what to do about these bindings. Seb
>> (or anyone else) are you interested in porting them to Go 1 and
>> maintaining them? Otherwise it may be time to deprecate them.
>
> I care enough for the go environment to keep the go bindings
> working. I've updated the bindings, the build infrastructure and the
> notmuch-addrlookup utility to go 1. I'll send a patch series as a
> followup that is meant to be applied upon Austins patch.
>
> The last patch in the series is a cleanup of the source code done with
> the gofmt utility. Go is somewhat strict in its coding conventions,
> but there is a utility that magically formats code. This makes the go
> code in the wild remarkably consistent. We should stick to the
> conventions too, hence this patch even if it breaks git blame
> somewhat.
>
> I haven't tested the bindings in depth, but the notmuch-addrlookup
> utility seems to be working fine.
kudos for picking this up.
I must say I don't use these go bindings in anger anymore: this was
mainly a test project for go.
(I am still a happy go user as well as a notmuch one, though, but I
prefer bbdb to notmuch-addrlookup)
-s
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2012-04-30 20:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-28 21:45 [PATCH] go: Update to the current notmuch_database_find_message API Austin Clements
2012-04-30 11:53 ` David Bremner
2012-04-30 19:54 ` Justus Winter
2012-04-30 19:55 ` [PATCH 1/5] go: reorganize the go bindings Justus Winter
2012-04-30 19:55 ` [PATCH 2/5] go: set LDFLAGS, fix include directive Justus Winter
2012-04-30 19:55 ` [PATCH 3/5] go: update the addrlookup utility to go 1 Justus Winter
2012-04-30 19:55 ` [PATCH 4/5] go: update the build system Justus Winter
2012-04-30 19:55 ` [PATCH 5/5] go: format the souce code using gofmt Justus Winter
2012-05-04 18:38 ` [PATCH 1/5] go: reorganize the go bindings Austin Clements
2012-05-04 18:43 ` Austin Clements
2012-05-05 11:15 ` Justus Winter
2012-05-09 11:15 ` [patch v2] update the go stuff to go 1 Justus Winter
2012-05-09 11:15 ` [PATCH 1/5] go: reorganize the go bindings Justus Winter
2012-05-09 11:15 ` [PATCH 2/5] go: set LDFLAGS to -lnotmuch in the packages source file Justus Winter
2012-05-09 11:15 ` [PATCH 3/5] go: update the addrlookup utility to go 1 Justus Winter
2012-05-09 11:15 ` [PATCH 4/5] go: update the build system Justus Winter
2012-05-09 11:15 ` [PATCH 5/5] go: format the souce code using gofmt Justus Winter
2012-05-09 18:10 ` [patch v2] update the go stuff to go 1 Austin Clements
2012-05-11 11:48 ` David Bremner
2012-04-30 20:14 ` Sebastien Binet [this message]
2012-05-04 11:56 ` [PATCH] go: Update to the current notmuch_database_find_message API David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjfldljm.fsf@cern.ch \
--to=seb.binet@gmail.com \
--cc=4winter@informatik.uni-hamburg.de \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).