unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Austin Clements <amdragon@MIT.EDU>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [Patch v8 4/6] Update devel/schemata for --entire-thread=false
Date: Sat, 23 Jun 2012 11:20:42 -0400	[thread overview]
Message-ID: <87sjdm12d1.fsf@awakening.csail.mit.edu> (raw)
In-Reply-To: <1339842107-10632-5-git-send-email-markwalters1009@gmail.com>

On Sat, 16 Jun 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> Also remove the Json --entire-thread item from devel/TODO.
> ---
>  devel/TODO     |    2 --
>  devel/schemata |    2 +-
>  2 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/devel/TODO b/devel/TODO
> index 7b750af..eb757af 100644
> --- a/devel/TODO
> +++ b/devel/TODO
> @@ -92,8 +92,6 @@ and email address in the From: line. We could also then easily support
>  "notmuch compose --from <something>" to support getting at alternate
>  email addresses.
>  
> -Fix the --format=json option to not imply --entire-thread.
> -
>  Implement "notmuch search --exclude-threads=<search-terms>" to allow
>  for excluding muted threads, (and any other negative, thread-based
>  filtering that the user wants to do).
> diff --git a/devel/schemata b/devel/schemata
> index 977cea7..8fcab8e 100644
> --- a/devel/schemata
> +++ b/devel/schemata
> @@ -32,7 +32,7 @@ thread = [thread_node*]
>  
>  # A message and its replies (show_messages)
>  thread_node = [
> -    message?,                 # present if --entire-thread or matched
> +    message?,                 # null if not matched and not --entire-thread

To keep with the syntax of the rest of this file, this should be
    message|null,

If this is the only thing to change in this series, maybe it should just
be a follow-up patch.

>      [thread_node*]            # children of message
>  ]
>  
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

  reply	other threads:[~2012-06-23 15:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-16 10:21 [Patch v8 0/6] Allow JSON to use non-entire thread, and use for elide Mark Walters
2012-06-16 10:21 ` [Patch v8 1/6] cli: command line parsing: allow default for keyword options Mark Walters
2012-06-16 10:21 ` [Patch v8 2/6] cli: Let json output "null" messages for non --entire-thread Mark Walters
2012-06-23 15:19   ` Austin Clements
2012-06-16 10:21 ` [Patch v8 3/6] cli: make --entire-thread=false work for format=json Mark Walters
2012-06-16 10:21 ` [Patch v8 4/6] Update devel/schemata for --entire-thread=false Mark Walters
2012-06-23 15:20   ` Austin Clements [this message]
2012-06-30  9:26     ` [PATCH] Minor correction to devel/schemata Mark Walters
2012-06-30 11:14       ` [Patch v2] " Mark Walters
2012-06-30 18:43         ` Austin Clements
2012-06-16 10:21 ` [Patch v8 5/6] emacs: make elide messages use notmuch-show for omitting messages Mark Walters
2012-06-16 10:21 ` [Patch v8 6/6] cli: notmuch-show.c fix whitespace error Mark Walters
2012-06-24 18:02 ` [Patch v8 0/6] Allow JSON to use non-entire thread, and use for elide David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sjdm12d1.fsf@awakening.csail.mit.edu \
    --to=amdragon@mit.edu \
    --cc=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).