From: David Bremner <david@tethera.net>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: make test_expect_equal_file() arguments flexible
Date: Sat, 01 Sep 2012 23:38:09 -0300 [thread overview]
Message-ID: <87sjb1b14e.fsf@zancas.localnet> (raw)
In-Reply-To: <1328080794-24670-1-git-send-email-dmitry.kurochkin@gmail.com>
Dmitry Kurochkin <dmitry.kurochkin@gmail.com> writes:
> Before the change, test_expect_equal_file() function treated the first
> argument as "actual output file" and the second argument as "expected
> output file". When the test fails, the files are copied for later
> inspection. The first files was copied to "$testname.output" and the
> second file to "$testname.expected". The argument order for
> test_expect_equal_file() is often wrong which results in confusing
> diff output and incorrectly named files.
pushed,
d
prev parent reply other threads:[~2012-09-02 2:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 7:19 [PATCH] test: make test_expect_equal_file() arguments flexible Dmitry Kurochkin
2012-02-01 8:12 ` David Edmondson
2012-02-01 8:47 ` Jameson Graef Rollins
2012-02-01 8:55 ` Tomi Ollila
2012-02-01 9:23 ` Dmitry Kurochkin
2012-02-01 9:19 ` Dmitry Kurochkin
2012-02-01 10:18 ` Tomi Ollila
2012-02-01 10:37 ` Dmitry Kurochkin
2012-02-01 17:24 ` Jameson Graef Rollins
2012-02-01 23:42 ` Dmitry Kurochkin
2012-02-02 0:07 ` Dmitry Kurochkin
2012-02-02 14:33 ` David Edmondson
2012-02-02 15:25 ` Tomi Ollila
2012-02-02 17:40 ` Jameson Graef Rollins
2012-09-02 2:38 ` David Bremner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sjb1b14e.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).