From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id A9EF5431FB6 for ; Wed, 21 Nov 2012 19:51:35 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zG3mPi50TSn6 for ; Wed, 21 Nov 2012 19:51:35 -0800 (PST) Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 3EE5D431FAF for ; Wed, 21 Nov 2012 19:51:35 -0800 (PST) Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net ([156.34.89.108] helo=zancas.localnet) by tesseract.cs.unb.ca with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1TbNp8-00032f-94; Wed, 21 Nov 2012 23:51:34 -0400 Received: from bremner by zancas.localnet with local (Exim 4.80) (envelope-from ) id 1TbNp2-0000zn-Q1; Wed, 21 Nov 2012 23:51:28 -0400 From: David Bremner To: Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH v3 2/2] notmuch-show.el: handle the case where icalendar-import-buffer returns nil In-Reply-To: <1352376480-29961-3-git-send-email-tomi.ollila@iki.fi> References: <1352376480-29961-1-git-send-email-tomi.ollila@iki.fi> <1352376480-29961-3-git-send-email-tomi.ollila@iki.fi> User-Agent: Notmuch/0.14+75~g984212d (http://notmuchmail.org) Emacs/24.1.1 (x86_64-pc-linux-gnu) Date: Wed, 21 Nov 2012 23:51:28 -0400 Message-ID: <87sj82wb0f.fsf@zancas.localnet> MIME-Version: 1.0 Content-Type: text/plain X-Spam_bar: - Cc: tomi.ollila@iki.fi X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2012 03:51:35 -0000 Tomi Ollila writes: > icalendar-import-buffer can fail by an error signal (which have been > witnessed) but according to its docstring it can also return nil > when failing (it returns t when succeeding). > > Now that the error is caught by the caller of notmuch-show-inset-part-* > functions in case icalendar-import-buffer returns nil an explicit > error is signaled and unwind-protect takes care of deleting the > temporary file (just in case, it is usually not written to the fs yet). This one looks OK to me too, although the API that makes it necessary out to be taken out back... d