From: Mark Walters <markwalters1009@gmail.com>
To: Peter Feigl <craven@gmx.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 0/5] New output format sexp (Lisp S-Expressions)
Date: Thu, 06 Dec 2012 08:22:15 +0000 [thread overview]
Message-ID: <87sj7jpp3c.fsf@qmul.ac.uk> (raw)
In-Reply-To: <1354779189-12231-1-git-send-email-craven@gmx.net>
On Thu, 06 Dec 2012, Peter Feigl <craven@gmx.net> wrote:
> This patch series adds a new output format "sexp" to notmuch-reply,
> notmuch-show and notmuch-search. These are useful for the Android mobile
> client and perhaps other Lisp programs as well.
> After the switch to a generic structured output printer, which was
> committed some months ago, these patches just add another one (like the
> json structured output printer).
> Basic tests and updates to the man pages are also included.
>
> This version includes the fixes according to Austin Clements'
> comments. It also changes the output from alists to plists, as these
> should work just as fine on all Lisps.
This is looking very nice: I haven't reviewed the first patch (the
sprinting itself) but the others look good (modulo the two small
points). I can confirm that the output works in notmuch show (with a two
line tweak to use s-expressions).
Best wishes
Mark
>
> Peter Feigl (5):
> Adding an S-expression structured output printer.
> Rename the -json printer functions in notmuch-reply and notmuch-show
> to generic -sprinter functions.
> Use the S-Expression structured printer in notmuch-show,
> notmuch-reply and notmuch-search.
> Adding tests for --format=sexp.
> Updating man pages for new S-Expression output format.
>
> Makefile.local | 1 +
> devel/schemata | 8 +-
> man/man1/notmuch-reply.1 | 14 ++-
> man/man1/notmuch-search.1 | 15 +--
> man/man1/notmuch-show.1 | 36 +++++--
> notmuch-client.h | 8 +-
> notmuch-reply.c | 48 ++++++----
> notmuch-search.c | 6 +-
> notmuch-show.c | 65 +++++++------
> sprinter-sexp.c | 238 ++++++++++++++++++++++++++++++++++++++++++++++
> sprinter.h | 4 +
> test/notmuch-test | 1 +
> test/sexp | 48 ++++++++++
> 13 files changed, 423 insertions(+), 69 deletions(-)
> create mode 100644 sprinter-sexp.c
> create mode 100755 test/sexp
>
> --
> 1.8.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2012-12-06 8:22 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-30 8:29 [PATCH 1/3] Adding an S-expression structured output printer Peter Feigl
2012-11-30 8:29 ` [PATCH 2/3] Use the S-Expression structured printer for notmuch search Peter Feigl
2012-11-30 18:04 ` Jani Nikula
2012-11-30 8:29 ` [PATCH 3/3] Use the S-Expression structured printer in notmuch show and notmuch reply Peter Feigl
2012-11-30 19:06 ` Jani Nikula
2012-11-30 8:34 ` [PATCH 1/3] Adding an S-expression structured output printer Peter Feigl
2012-11-30 17:26 ` Jani Nikula
2012-11-30 19:11 ` Jani Nikula
2012-12-01 9:59 ` Mark Walters
2012-12-01 11:34 ` Tomi Ollila
2012-12-01 12:24 ` Mark Walters
2012-12-01 13:29 ` Tomi Ollila
2012-12-01 13:45 ` Mark Walters
2012-12-01 14:26 ` Mark Walters
2012-12-01 15:46 ` Mark Walters
2012-12-01 15:18 ` Austin Clements
2012-12-01 16:14 ` Mark Walters
2012-12-04 14:46 ` [PATCH v2 0/5] New output format sexp (Lisp S-Expressions) Peter Feigl
2012-12-04 17:07 ` Jani Nikula
2012-12-06 7:33 ` [PATCH v3 " Peter Feigl
2012-12-06 8:22 ` Mark Walters [this message]
2012-12-07 2:54 ` Jameson Graef Rollins
2012-12-06 7:33 ` [PATCH v3 1/5] Adding an S-expression structured output printer Peter Feigl
2012-12-06 7:33 ` [PATCH v3 2/5] Rename the -json printer functions in notmuch-reply and notmuch-show to generic -sprinter functions Peter Feigl
2012-12-06 7:33 ` [PATCH v3 3/5] Use the S-Expression structured printer in notmuch-show, notmuch-reply and notmuch-search Peter Feigl
2012-12-06 7:33 ` [PATCH v3 4/5] Adding tests for --format=sexp Peter Feigl
2012-12-06 8:18 ` Mark Walters
2012-12-06 7:33 ` [PATCH v3 5/5] Updating man pages for new S-Expression output format Peter Feigl
2012-12-06 8:19 ` Mark Walters
2012-12-04 14:46 ` [PATCH v2 1/5] Adding an S-expression structured output printer Peter Feigl
2012-12-04 19:14 ` Austin Clements
2012-12-04 14:46 ` [PATCH v2 2/5] Rename the -json printer functions in notmuch-reply and notmuch-show to generic -sprinter functions Peter Feigl
2012-12-04 19:18 ` Austin Clements
2012-12-04 14:46 ` [PATCH v2 3/5] Use the S-Expression structured printer in notmuch-show, notmuch-reply and notmuch-search Peter Feigl
2012-12-04 19:22 ` Austin Clements
2012-12-04 14:46 ` [PATCH v2 4/5] Adding tests for --format=sexp Peter Feigl
2012-12-04 19:24 ` Austin Clements
2012-12-04 14:46 ` [PATCH v2 5/5] Updating man pages for new S-Expression output format Peter Feigl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj7jpp3c.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=craven@gmx.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).