From: David Bremner <david@tethera.net>
To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
Cc: tomi.ollila@iki.fi
Subject: Re: [PATCH 1/1] lib/message-file.c: use g_malloc () & g_free () in hash table values
Date: Sat, 22 Dec 2012 09:21:40 -0400 [thread overview]
Message-ID: <87sj6yte6z.fsf@zancas.localnet> (raw)
In-Reply-To: <1356112321-6332-1-git-send-email-tomi.ollila@iki.fi>
Tomi Ollila <tomi.ollila@iki.fi> writes:
> @@ -111,7 +111,7 @@ _notmuch_message_file_open_ctx (void *ctx, const char *filename)
> message->headers = g_hash_table_new_full (strcase_hash,
> strcase_equal,
> free,
> - free);
> + g_free);
It slightly icky that the keys in this hash table are allocated/freed
with (x)malloc/(x)free, and the values with g_malloc/g_free, but that's
not your fault, and it's an improvement on what we had before, so +1
from me.
d
next prev parent reply other threads:[~2012-12-22 13:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 17:52 [PATCH 1/1] lib/message-file.c: use g_malloc () & g_free () in hash table values Tomi Ollila
2012-12-22 13:21 ` David Bremner [this message]
2012-12-24 20:46 ` Austin Clements
2012-12-24 23:06 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sj6yte6z.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).